1539230 - Use Validation Higher Order Component with subtest distribution and compare selector views

Status: RESOLVED FIXED

(Tree Management :: Perfherder, enhancement, P3)

Description

[Sarah Clements [:sclements]]

The Validation HOC was created for use with the compare and compare subtest views but can replace duplicated stateful logic in the compare subtest distribution and possibly the compare chooser views. It fetches repositories and frameworks, validates query parameters which are all passed as props as this.props.validated to the wrapped component and handles its own errors pertaining to the above mentioned.

It lives here: https://github.com/mozilla/treeherder/blob/master/ui/perfherder/compare/Validation.jsx

Comment 1

[Sarah Clements [:sclements]]

Ionut, do you want to work on this since you converted the subtest distribution view?

Comment 2

[Ionuț Goldan [:igoldan]]

(In reply to Sarah Clements [:sclements] from comment #1)

Ionut, do you want to work on this since you converted the subtest distribution view?

I would really like to, but I have 2 P1s at the moment. Bug 1528731 is one of them and it's pretty urgent.
I'm afraid I have to skip this task.

Comment 3

[Sarah Clements [:sclements]]

This is not urgent so it can be done at a later point by whomever is available (preferably before we wrap up the conversion).

Comment 4

[Sarah Clements [:sclements]]

I went with a slightly different approach - the projects and frameworks are fetched from the top-level app component and passed as props to the subtest distribution view in this commit: https://github.com/mozilla/treeherder/commit/59737af7719d0dffb90419b3878ff5c22b001452