Closed Bug 1539284 Opened 1 year ago Closed 1 year ago

Remove some redundant functions from urlbar's head-common.js

Categories

(Firefox :: Address Bar, enhancement, P5)

enhancement

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

I noticed there's a few functions in head-common.js that we can clear out now.

is_element_hidden has an extra check for the element not being null, but I really don't think that's necessary since BrowserTestUtils.is_hidden will throw in that case.

promisePopupShown is only used by the legacy code, so we can move it across to the legacy head file.

The other functions are just unused.

I think later we could maybe remove the promise* functions and just call the utils direct, though we might also want to keep them for ease of use.

Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/cb765b150c52
Remove some redundant functions from urlbar's head-common.js. r=adw
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.