1539300 - AAarch64 Security Testing actions

Status: RESOLVED WONTFIX

(Firefox Graveyard :: Security: Review Requests, task, P1)

Description

[Paul Theriault [:pauljt] (no longer reading bugmail)]

Security Testing action requested from the security review of AArch64 windows.

• Make sure the updater is correctly verifying signatures and enforcing the security rules we have on update metadata (matching product and channel, must not be a lower version, etc.). There may be in-tree tests for this for intel windows builds but they would need to be ported.

• Audit the compiler/linker security features enabled (or disabled) to make sure we're not missing protective features we use in our regular releases.

• Test/audit that all of our processes have the expected sandbox privilege level

Comment 1

[(Away)]

(In reply to Paul Theriault [:pauljt] from comment #0)

• Audit the compiler/linker security features enabled (or disabled) to make
  sure we're not missing protective features we use in our regular releases.

Take note of bug 1526443, but it should get resolved at our next update of rust.

Comment 2

[Stephanie Ouillon [:arroway] (needinfo me)]

I collected my findings regarding the compiler/linker security features in this doc, what I did is reviewing the diffs between win64 and win-aarch64 files:
https://docs.google.com/document/d/1zn9ZpMi0oz04pvlBB09UFasuE063equoNZjPTXUF9zg/edit

Nothing is outstanding from my perspective, but I'm sharing the recap in case a particular setting happens to have an indirect implication on security I didn't see.

Comment 3

[Nathan Froyd [:froydnj]]

(In reply to Stephanie Ouillon [:arroway] (needinfo me) from comment #2)

I collected my findings regarding the compiler/linker security features in this doc, what I did is reviewing the diffs between win64 and win-aarch64 files:
https://docs.google.com/document/d/1zn9ZpMi0oz04pvlBB09UFasuE063equoNZjPTXUF9zg/edit

Nothing is outstanding from my perspective, but I'm sharing the recap in case a particular setting happens to have an indirect implication on security I didn't see.

Added some explanatory comments in the doc. Thanks!

Comment 4

[Frederik Braun [:freddy] (reo duty for Fx124)]

Closing outdated, unassigned review requests for a non-existent team.