1539323 - Preferences tab should only be scrollable if overflowing

Status: VERIFIED FIXED

(Thunderbird :: Preferences, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Currently all preference panes are the same height, because they're in a <deck>. This means we get a scrollbar if the tallest pane cannot fit in the space available. This looks silly for short panes.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1539323-prefpane-deck-1.diff

Comment 2

[Richard Marti (:Paenglab)]

Comment on attachment 9053806 [details] [diff] [review]
1539323-prefpane-deck-1.diff

Thanks.

Maybe in the future we could implement it the FX way with hiding the groupboxes of a pane. Then we can also add a search functionality.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/e54ef7d0e92f
Stop displaying preferences in a <deck> to prevent unnecessary overflowing. r=Paenglab DONTBUILD

Comment 4

[Hades]

Works for me in 68.0a1 April5 @Kubuntu 18.10

No scrolling in full size > I need a very small window to see a scroll bar.

Comment 5

[Jorg K (CEST = GMT+2)]

Please DO NOT change FIXED to WORKSFORME. The latter is for bugs that can't be reproduced, so some one says: This already works for me. When a fix was landed, the status MUST remain FIXED.

Comment 6

[Jorg K (CEST = GMT+2)]

There is also no point changing the tracking flags. They are for tracking bugs where patches need backport/uplift. These are for the TB code manager to use and no one else.

Comment 7

[Hades]

Sorry, I wasn't sure how to give correct feedback. Thanks for information - won't do it again.

Comment 8

[Wayne Mery (:wsmwk)]

verified per hades