1539328 - [remote-dbg-next] Inspect workers without re-using debugger client in about:devtools-toolbox

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Daisuke Akatsuka (:daisuke)]

This is a followup bug 1505813.
For now, we are using cached actor to inspect workers. In that bug as well, to do same way in toolbox as well which opened in new tab, we re-use debugger client for this-firefox.
However, we better retrieve the worker actor without re-using debugger client.

To resolve this, it seems we need to introduce something unique id for the workers instead of actorID since the id depends on debugger client instances. Then create a function like client.mainRoot.getAddon, then use this.

Comment 1

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1539328: Introduce getWorker(id) to RootFront to avoid re-using client debugger. r?jdescottes

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1539328: Introduce new unique id for normal worker actor. r?jdescottes

Depends on D25207

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1539328: Introduce new unique id for service worker actor. r?jdescottes

Depends on D25771

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ba17b00839b4
Introduce getWorker(id) to RootFront to avoid re-using client debugger. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/6bc5500525be
Introduce new unique id for normal worker actor. r=jdescottes,bhackett
https://hg.mozilla.org/integration/autoland/rev/634e0a2391cc
Introduce new unique id for service worker actor. r=jdescottes

Comment 5

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/ba17b00839b4
https://hg.mozilla.org/mozilla-central/rev/6bc5500525be
https://hg.mozilla.org/mozilla-central/rev/634e0a2391cc