1539379 - Windows 7 classic theme inactive tab text color lacks contrast for light/dark themes

Status: VERIFIED FIXED

(Firefox :: Theme, defect, P5)

Description

[Kestrel]

Attachment: Windows Classic theme white text on light background

Inactive tabs have white text on light background or black text on dark background making them difficult to read on Windows 7 when using classic theme with light/dark theme.

The following theme combinations are affected:

Windows Classic
Light theme (active window)

High Contrast #1 & High Contrast White
Light theme (active window)
Dark theme (inactive window)

High Contrast #2
Light theme (inactive window)
Dark theme (active window)

High Contrast Black
Light theme (active and inactive window)

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0b162c810600246a9273f337c8b23481f7f721&tochange=e1f93e89556df2f1147ad2ef2cb38b1309d44ad4

Regressed by Bug 1503306.

Comment 1

[Kestrel]

Attachment: High Contrast #2 theme black text on dark background

Comment 2

[Kestrel]

User reports indicate it can affect the default Windows 7 theme as well:
https://www.reddit.com/r/firefox/comments/b5dyk5/tab_text_changing_to_black_on_black_when/
https://www.reddit.com/r/firefox/comments/a7untv/help_black_text_on_black_background_mozilla_dark/
https://www.reddit.com/r/firefox/comments/a5ezmx/firefox_dark_theme_on_windows_has_black_text_on/
https://www.reddit.com/r/firefox/comments/abe981/tabs_font_color_stuck_on_black/

All reports are after FF64 when the regressing bug landed.

Comment 3

[Kestrel]

Attachment: Bug 1539379 - Ensure light/dark theme uses correct tab text color for Windows 7 classic theme

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7a8efbb255f9
Ensure light/dark theme uses correct tab text color for Windows 7 classic theme r=dao

Comment 5

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/7a8efbb255f9

Comment 6

[Florencia Di Ciocco, NI to vbalducci]

Hi Kestrel,

I tried to reproduce the bug in Windows 7 32 bits and 64 bits and windows 10 64 bits. I tried it on Nightly 64, 66 and 69 and release 64 and 66. I was not able to reproduce it. The steps I took were:

1. Open FF with a new profile
2. open some tabs
3. right click on the hamburger menu
4. choose customize
5. select the dark or light theme

Is there a trick to reproduce this bug?

Thanks in advance, Florencia.

Comment 7

[Kestrel]

On Windows 7 you need to go to Personalization and enable the "Windows Classic" theme or one of the "High Contrast" themes. Windows 10 is not applicable.

Comment 8

[Florencia Di Ciocco, NI to vbalducci]

Hi Kestrel,

Thanks so much for the help! I tested this issue on Windows 7 64 bits with the Nightly build before the fix and was able to reproduce it. I also tested it using the latest Nightly build (30/5/2019) and I'm not able to reproduce the issue. Based on this I will mark the bug as Verified.

Best regards, Flor.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Please nominate this for Beta uplift when you get a chance.

Comment 10

[Kestrel]

Comment on attachment 9067715 [details]
Bug 1539379 - Ensure light/dark theme uses correct tab text color for Windows 7 classic theme

Beta/Release Uplift Approval Request

• User impact if declined: Non-active tab titles will be difficult or impossible to read with some combinations of light/dark theme and Classic system themes on Windows 7.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Single cosmetic style change limited to Windows 7/8.
• String changes made/needed:

Comment 11

[Julien Cristau [:jcristau]]

Comment on attachment 9067715 [details]
Bug 1539379 - Ensure light/dark theme uses correct tab text color for Windows 7 classic theme

windows css fix, approved for 68.0b9

Comment 12

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/46f0e514450c