Closed Bug 1539379 Opened 7 months ago Closed 5 months ago

Windows 7 classic theme inactive tab text color lacks contrast for light/dark themes

Categories

(Firefox :: Theme, defect, P5)

64 Branch
Unspecified
Windows 7
defect

Tracking

()

VERIFIED FIXED
Firefox 69
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed
firefox69 --- verified

People

(Reporter: ke5trel, Assigned: ke5trel)

References

(Regression)

Details

(Keywords: regression)

Attachments

(3 files)

Inactive tabs have white text on light background or black text on dark background making them difficult to read on Windows 7 when using classic theme with light/dark theme.

The following theme combinations are affected:

Windows Classic
Light theme (active window)

High Contrast #1 & High Contrast White
Light theme (active window)
Dark theme (inactive window)

High Contrast #2
Light theme (inactive window)
Dark theme (active window)

High Contrast Black
Light theme (active and inactive window)

Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0b162c810600246a9273f337c8b23481f7f721&tochange=e1f93e89556df2f1147ad2ef2cb38b1309d44ad4

Regressed by Bug 1503306.

No longer blocks: 1503306
Regressed by: 1503306
Assignee: nobody → ke5trel
Flags: qe-verify+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7a8efbb255f9
Ensure light/dark theme uses correct tab text color for Windows 7 classic theme r=dao
Status: NEW → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69

Hi Kestrel,

I tried to reproduce the bug in Windows 7 32 bits and 64 bits and windows 10 64 bits. I tried it on Nightly 64, 66 and 69 and release 64 and 66. I was not able to reproduce it. The steps I took were:

  1. Open FF with a new profile
  2. open some tabs
  3. right click on the hamburger menu
  4. choose customize
  5. select the dark or light theme

Is there a trick to reproduce this bug?

Thanks in advance, Florencia.

Flags: needinfo?(ke5trel)

On Windows 7 you need to go to Personalization and enable the "Windows Classic" theme or one of the "High Contrast" themes. Windows 10 is not applicable.

Flags: needinfo?(ke5trel)

Hi Kestrel,

Thanks so much for the help! I tested this issue on Windows 7 64 bits with the Nightly build before the fix and was able to reproduce it. I also tested it using the latest Nightly build (30/5/2019) and I'm not able to reproduce the issue. Based on this I will mark the bug as Verified.

Best regards, Flor.

Status: RESOLVED → VERIFIED
Flags: qe-verify+

Please nominate this for Beta uplift when you get a chance.

Flags: needinfo?(ke5trel)

Comment on attachment 9067715 [details]
Bug 1539379 - Ensure light/dark theme uses correct tab text color for Windows 7 classic theme

Beta/Release Uplift Approval Request

  • User impact if declined: Non-active tab titles will be difficult or impossible to read with some combinations of light/dark theme and Classic system themes on Windows 7.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Single cosmetic style change limited to Windows 7/8.
  • String changes made/needed:
Flags: needinfo?(ke5trel)
Attachment #9067715 - Flags: approval-mozilla-beta?

Comment on attachment 9067715 [details]
Bug 1539379 - Ensure light/dark theme uses correct tab text color for Windows 7 classic theme

windows css fix, approved for 68.0b9

Attachment #9067715 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.