1539408 - Opening links from some about:* pages in a new private window doesn't work

Status: VERIFIED FIXED

(Firefox :: Untriaged, defect)

Description

[tgn-ff]

User Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

1. Open Firefox with a clean profile.
2. Open about:support.
3. Right click on about:plugins (or any other link in the page) and select to open it in a new private window.

Actual results:

The link didn't open.

Expected results:

It should open a new private window with about:plugins loaded.

It's a regression. Mozregression points to Bug 1528695.

19:18.21 INFO: Last good revision: 6c08bfd19a365a958118d2a44ff4d36773e9f3c0
19:18.21 INFO: First bad revision: 4d62ab0e31fd6918ca95763914a8bdf41afe757a
19:18.21 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=6c08bfd19a365a958118d2a44ff4d36773e9f3c0&tochange=4d62ab0e31fd6918ca95763914a8bdf41afe757a

Comment 1

[Thomas Nguyen (:tnguyen)]

Attachment: Bug 1539408 Pass referrerInfo to gContextMenuContentData in non-remote

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f82deba8ba6
Pass referrerInfo to gContextMenuContentData in non-remote r=Gijs

Comment 3

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/1f82deba8ba6

Comment 4

[Thomas Nguyen (:tnguyen)]

Comment on attachment 9054519 [details]
Bug 1539408 Pass referrerInfo to gContextMenuContentData in non-remote

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1528695
• User impact if declined: Could not open some links in about:support in private window
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: Yes
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: Comment 0 in bug 1528695
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): The problem is we could not find referrerInfo object in that case, we only need to create one to pass around.
• String changes made/needed: No

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

I'd like to see the fix verified by QA on Nightly before uplifting to beta.

Comment 6

[tgn-ff]

As the reporter, I can verify that the fix landed in Nightly with Build ID 20190402214908 and beyond. Since I'm not QA, I'll leave it to someone who is to change the status.

Comment 7

[Daniel Cicas [:dcicas], Release QA]

Hello,

I reproduced this issue using Fx 68.0a1 Build Id: 20190327175114 on Windows 10 x64.

I can confirm that this issue is fixed in Fx 68.0a1 Build Id: 20190404014638 on Windows 10 x64, Ubuntu 18.04 and macOS 10.13.

I am leaving the qe-verify+ on this bug so that the bug can be verified on Beta once uplifted.

Comment 8

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9054519 [details]
Bug 1539408 Pass referrerInfo to gContextMenuContentData in non-remote

67 regression, patch verified by QA in Nightly, uplifted accepted for 67 beta 9, thanks.

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/releases/mozilla-beta/rev/ca218beefd31

Comment 10

[Daniel Cicas [:dcicas], Release QA]

Hello,

I verified and can confirm that this issue is fixed for Fx 67.0b9 on Windows 10 x64, Ubuntu 18.14 and mac OS 10.14.