1539419 - Glitches when enlarging videos on Facebook

Status: NEW

(Core :: Graphics, defect, P3)

Description

[Alexandru Trif, QA [:atrif]]

Affected versions

• Firefox 67.0b5 (20190325125126)
• Firefox 68.0a1 (20190326214944)
• Firefox 66.0.2 (20190326175229)

Affected platforms

• macOS 10.14
• Ubuntu 18.04 x64

[Prerequisites]:

• Have a valid facebook account.

Steps to reproduce

1. Open Firefox and go https://www.facebook.com/.
2. Login with the account from the prerequisites.
3. Start a random video and select “Click to enlarge”.

Expected result

• The video is enlarged smoothly without any visual glitches.

Actual result

• Glitches appear on enlarging the video.

Regression range

• I will search for a regression range ASAP.

Additional Notes

• On Ubuntu the transition is less laggy.
• The issue is more visible when the browser is in fullscreen mode.
• Attached a screen recording with the issue: link.

Comment 1

[Jean-Yves Avenard [:jya]]

What make you think this is a regression?

Comment 2

[Alexandru Trif, QA [:atrif]]

Hello,

After further investigation on this issue I found this information:

• the issue is reproducible on MacBook Pro (GPU- Intel Iris Plus Graphics 650) which has macOS 10.14 and macOS 10.13 (tested on both) all the way back to Firefox 56.0a1 2017-08-01(20170801100311) which can load the video. On older versions like Firefox 55.0a1-2017-06-01(20170601030206) the videos don’t load. Tested on Chrome too and I can’t reproduce the issue.
• I tested on another MacBook Pro with macOS 10.14 (GPU- Intel Iris Pro) on Firefox 68.0a1 (20190327175114) and the issue still reproduce.
• I also tested on two iMac’s (GPU - Intel Iris Pro) on macOS 10.14 and macOS 10.13 using Firefox 68.0a1(20190327175114) and the transition when enlarging the video is much smoother, and the behavior presented in comment 0 it’s not reproducible so I’m guessing it’s a MacBook Pro problem.

I don’t think this is a regression. If I can help you with more information please let me know. Thank you!

Comment 3

[Michael Froman [:mjf]]

Nils, who should take a look at this?

Comment 4

[neerajdana9]

For best software development courses visit https://www.smartcodehub.com

Comment 5

[Jason Burton]

I was able to reproduce this issue on macOS 10.15.

Comment 6

[Paul Adenot (:padenot)]

It's smooth for me here, but my machine is very very fast. I wouldn't be surprised that all the optimizations markus made on macOS recently made a difference.

Can Alexandru, can you re-test with similar hardware you used?

Comment 7

[Alexandru Trif, QA [:atrif]]

(In reply to Paul Adenot (:padenot) from comment #6)

It's smooth for me here, but my machine is very very fast. I wouldn't be surprised that all the optimizations markus made on macOS recently made a difference.

Can Alexandru, can you re-test with similar hardware you used?

Hello Paul!
I tested using the same MacBook Pro with Intel Iris Plus Graphics 650 1536 MB on Firefox 74.0a1 (20200109213942) but this time having macOS 10.15 installed. Unfortunately, the issue is still reproducing here. Here's the screen recording.
Also, I've tested on an IMac with Intel Iris Pro and macOS 10.15, Firefox 74.0a1 (20200109213942) and the transition si way smoother than on MacBook Pro. Made a screen recording.

Comment 8

[Paul Adenot (:padenot)]

Ok this really is machine dependent then, which points to the fact that we need to generally make this faster. It would be good to have a profile, is that something that you could do? We'd really need the compositor thread there.

Comment 9

[Alexandru Trif, QA [:atrif]]

(In reply to Paul Adenot (:padenot) from comment #8)

Ok this really is machine dependent then, which points to the fact that we need to generally make this faster. It would be good to have a profile, is that something that you could do? We'd really need the compositor thread there.

This is ok? If any more information is needed please let me know. Updated the link.

Comment 10

[Paul Adenot (:padenot)]

Yep, looks like this captures what we need, lots of js as well, as expected on fb, but only a graphics person can tell.

Does enabling WebRender make things better? gfx.webrender.all to true in about:config, and restart Firefox.

Comment 11

[Alexandru Trif, QA [:atrif]]

(In reply to Paul Adenot (:padenot) from comment #10)

Yep, looks like this captures what we need, lots of js as well, as expected on fb, but only a graphics person can tell.

Does enabling WebRender make things better? gfx.webrender.all to true in about:config, and restart Firefox.

Yup. Definitely enabling WebRender makes this way smoother. Made a screen recording.

Comment 12

[Paul Adenot (:padenot)]

Jessie, this is a perf problem that has a profile, macOS only, where WebRender makes a huge difference (effectively solving the issue), can you decide what to do with it? I don't know if we want to invest in fixing a bug like this with WR being actively worked on to ship.

Comment 13

[Jessie [:jbonisteel] pls NI]

Yes, we are somewhat working on getting WR to a shipable state for Mac although I don't have a target for it yet. Does this seem like a regression? If we can figured out a regression window we could look to see if there is a simple intermediary fix.

Comment 14

[Jessie [:jbonisteel] pls NI]

Ah, just saw that QA does not think it is a regression after all.

Comment 15

[Jessie [:jbonisteel] pls NI]

Then I think the answer for now is to wait for WR.

Comment 16

[Paul Adenot (:padenot)]

Not a regression indeed. Quite the opposite in fact, it's better than it used to, but still not good enough.

This is very smooth when using WR, so this will be in all likelihood just a matter of making sure nothing has regressed this when we ship WR, and closing this. Thanks!