1539423 - Response headers are in small case

Status: RESOLVED FIXED

(DevTools :: Netmonitor, defect, P3)

Description

[Dhyey Thakore [:dhyey35]]

Attachment: netmonitor-rr-1.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce:

Steps:

1. Open netmonitor and go to : https://www.google.com/
2. Open the first request and in Headers panel see the keys ( content-length, content-type etc.. ) in Response headers and compare the key names of Request headers

Actual results:

The response headers are in all small case while request headers are in camel case ( First letter capital ).

Expected results:

Response headers should be in camel case too.

Comment 1

[Dhyey Thakore [:dhyey35]]

Attachment: netmonitor-rr-2.png

Issue screenshot

Comment 2

[Dhyey Thakore [:dhyey35]]

One weird thing is that in some cases it does display properly in camel case - see attachment netmonitor-rr-1.png
url: https://bug1469826.bmoattachments.org/attachment.cgi?id=8986431

Open up details of any request.

The difference between those two URLs is that google uses HTTP ver 2 while the mentioned url uses HTTP/1.1

Comment 3

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Valentin, is this a feature or a bug?

Honza

Comment 4

[Valentin Gosu [:valentin] (he/him)]

It seems to be a HTTP/2 feature :)

https://searchfox.org/mozilla-central/rev/a7315d78417179b151fef6108f2bce14786ba64d/netwerk/protocol/http/Http2Compression.cpp#1102

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Note that I see the exact same behaviour in Chrome devtools.

Comment 6

[Dhyey Thakore [:dhyey35]]

As this is a feature, I think we should document it netmonitor codebase too so such a confusion doesn't arise again.

Comment 7

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to dhyey35 from comment #6)

As this is a feature, I think we should document it netmonitor codebase too so such a confusion doesn't arise again.

Agree, do you have any particular places in mind?

Also, we might want to update MDN:
https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor/request_details

Honza

Comment 8

[Dhyey Thakore [:dhyey35]]

I didn't have any particular place in mind but I think here - https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/HeadersPanel.js#376 might be a good place. Do let me know if you have a better place.

I have updated the MDN doc and also added link to the RFC section that specifies this rule.

Comment 9

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Thanks!

I think that we can update the general comment related to the HeadersPanel component:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/HeadersPanel.js#65

The comment should

• short explanation about response headers using small case
• link to the MDN page
• link to related RFC

Thanks!
Honza

Comment 10

[Dhyey Thakore [:dhyey35]]

Attachment: Bug 1539423 - Netmonitor docs: http/2 response headers are in small case

Add comment in HeadersPanel

Comment 11

[Dhyey Thakore [:dhyey35]]

Is the comment format proper ?

Comment 12

[Jan Honza Odvarko [:Honza] (always need-info? me)]

(In reply to dhyey35 from comment #11)

Is the comment format proper ?
Yes (I just landed that)

Thanks,
Honza

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5ac0e5883bae
Netmonitor docs: http/2 response headers are in small case r=Honza

Comment 14

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/5ac0e5883bae