Closed Bug 1539423 Opened 8 months ago Closed 8 months ago

Response headers are in small case

Categories

(DevTools :: Netmonitor, defect, P3)

68 Branch
defect

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: dhyey35, Assigned: dhyey35)

Details

(Keywords: dev-doc-needed, Whiteboard: [qa-68b-p2])

Attachments

(3 files)

Attached image netmonitor-rr-1.png

User Agent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.98 Safari/537.36

Steps to reproduce:

Steps:

  1. Open netmonitor and go to : https://www.google.com/
  2. Open the first request and in Headers panel see the keys ( content-length, content-type etc.. ) in Response headers and compare the key names of Request headers

Actual results:

The response headers are in all small case while request headers are in camel case ( First letter capital ).

Expected results:

Response headers should be in camel case too.

Component: Untriaged → Netmonitor
Product: Firefox → DevTools
Attached image netmonitor-rr-2.png

Issue screenshot

One weird thing is that in some cases it does display properly in camel case - see attachment netmonitor-rr-1.png
url: https://bug1469826.bmoattachments.org/attachment.cgi?id=8986431

Open up details of any request.

The difference between those two URLs is that google uses HTTP ver 2 while the mentioned url uses HTTP/1.1

Flags: needinfo?(odvarko)

Valentin, is this a feature or a bug?

Honza

Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(odvarko) → needinfo?(valentin.gosu)
Priority: -- → P3
Flags: needinfo?(valentin.gosu)

Note that I see the exact same behaviour in Chrome devtools.

As this is a feature, I think we should document it netmonitor codebase too so such a confusion doesn't arise again.

Flags: needinfo?(odvarko)

(In reply to dhyey35 from comment #6)

As this is a feature, I think we should document it netmonitor codebase too so such a confusion doesn't arise again.

Agree, do you have any particular places in mind?

Also, we might want to update MDN:
https://developer.mozilla.org/en-US/docs/Tools/Network_Monitor/request_details

Honza

Flags: needinfo?(odvarko) → needinfo?(dhyey35)
Keywords: dev-doc-needed

I didn't have any particular place in mind but I think here - https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/HeadersPanel.js#376 might be a good place. Do let me know if you have a better place.

I have updated the MDN doc and also added link to the RFC section that specifies this rule.

Flags: needinfo?(dhyey35) → needinfo?(odvarko)

Thanks!

I think that we can update the general comment related to the HeadersPanel component:
https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/src/components/HeadersPanel.js#65

The comment should

  • short explanation about response headers using small case
  • link to the MDN page
  • link to related RFC

Thanks!
Honza

Flags: needinfo?(odvarko)

Is the comment format proper ?

Flags: needinfo?(odvarko)
Assignee: nobody → dhyey35
Status: NEW → ASSIGNED
Flags: needinfo?(odvarko)

(In reply to dhyey35 from comment #11)

Is the comment format proper ?
Yes (I just landed that)

Thanks,
Honza

Pushed by jodvarko@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5ac0e5883bae
Netmonitor docs: http/2 response headers are in small case r=Honza
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Whiteboard: [qa-68b-p2]
You need to log in before you can comment on or make changes to this bug.