Closed Bug 1539426 Opened 7 months ago Closed 7 months ago

Invalid files-changed regex for source-test-clang-{tidy,format} tasks

Categories

(Firefox Build System :: Task Configuration, task)

task
Not set

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: bastien, Assigned: bastien)

Details

Attachments

(1 file)

I started running live tests for the code review bot using Try tasks, and i noticed that commits with C/C++ files do not trigger the clang-tidy & clang-format tasks.

In the decision log tasks, we can see :

3 commits influencing task scheduling:
  44dae4e1ff94 Patch PHID-DIFF-nz72cnzitohkqewhvgza
  db5759a26fea Patch PHID-DIFF-6ico2mpw4mswdjqlojp4
  24693832a9a2 try_task_config for PHID-DIFF-6ico2mpw4mswdjqlojp4
...

no files found matching a pattern in `skip-unless-changed` for source-test-clang-format
no files found matching a pattern in `skip-unless-changed` for source-test-clang-tidy

Whereas the targeted revisions has .h files modifications.

Moving regexes from **.h to **/*.h will solve this issue

Attachment #9053887 - Attachment description: Bug 1539426 - Fix clang CI tasks regexes, r=tomprince → Bug 1539426 - Fix clang CI tasks globs, r=tomprince
Pushed by babadie@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b0e059604791
Fix clang CI tasks globs, r=tomprince
Status: ASSIGNED → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.