1539483 - Bookmarks keyword search query is slow and non-cancellable

Status: RESOLVED FIXED

(Firefox for iOS :: Data Storage, enhancement, P1)

Description

[Justin D'Arcangelo [:justindarc]]

When you enter a search term in the awesomebar with a space in it, we run a query to determine if there is a bookmark matching a keyword search term such as:

"imdb godfather"

There are several problems with this:
1.) This query does full table scans since keyword is not indexed
2.) This query is not cancellable (i.e., if it hangs and the user taps on a search suggestion instead of waiting, the browser will then navigate the user away from the page they're on after this query finally resolves)
3.) This query runs on the read-write DB connection so it may be blocked waiting for another write operation to complete

We should address all three of these things.

Comment 1

[Justin D'Arcangelo [:justindarc]]

Landed on master:

https://github.com/mozilla-mobile/firefox-ios/commit/0834048bc6c38b924d54a549f52cf2a0db6c2887