Closed Bug 1539493 Opened 6 months ago Closed 6 months ago

Memoize setSymbols

Categories

(DevTools :: Debugger, enhancement, P3)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

There are several places, which use symbols, which either assume they are fetched or try to re-fetch. This can be dangerous because in large files, the worker will return multiple instances of the symbols data-structure as opposed to relying on symbols from the store.

As a side-note, it would be nice to fold sourceMetaData into symbols to reduce the number of async operations.

Priority: -- → P3
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f94f3248e560
Remove source metadata. r=loganfsmyth
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Assignee: nobody → jlaster

i have another commit

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by jlaster@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/196f7c24339e
memoize setSymbols call. r=loganfsmyth
Status: REOPENED → RESOLVED
Closed: 6 months ago6 months ago
Resolution: --- → FIXED
Depends on: 1542230
Regressions: 1540803
Regressions: 1541258
You need to log in before you can comment on or make changes to this bug.