Closed Bug 1539544 Opened 6 years ago Closed 6 years ago

User reports a default preference isn't showing up in their profile

Categories

(Core :: Preferences: Backend, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED INVALID

People

(Reporter: mconley, Unassigned)

Details

In bug 1535748, I removed some #ifdef's around setting the media.videocontrols.picture-in-picture.enabled pref to false by default on Nightly in all.js:

https://searchfox.org/mozilla-central/rev/a7315d78417179b151fef6108f2bce14786ba64d/modules/libpref/init/all.js#448

While I was livehacking, a user on Nightly reported to me that their profile doesn't appear to have the pref available and set to false, and so this point in our context menu code:

https://searchfox.org/mozilla-central/rev/3d469329a42644b41e66944d8da22d78d8c0f5ec/browser/base/content/nsContextMenu.js#683

throws an exception because the pref is, for some reason, not available.

Hey njn, have you heard of this sort of thing before? Is there some diagnostic or logging that might help figure out what happened here? What's the best way for this user to move forward?

Flags: needinfo?(n.nethercote)

The user got back to me - apparently, the pref in question is being ifdef'd out because they have a custom build of Firefox and the pref happens to be in the ifdef'd out chunk (though it's unrelated).

Status: NEW → RESOLVED
Closed: 6 years ago
Flags: needinfo?(n.nethercote)
Resolution: --- → INVALID

Because they disabled webrtc? That begs the question, does picture-in-picture require webrtc?

You need to log in before you can comment on or make changes to this bug.