Move Picture-in-Picture prefs outside of the MOZ_WEBRTC ifdef
Categories
(Toolkit :: Video/Audio Controls, enhancement, P3)
Tracking
()
Tracking | Status | |
---|---|---|
firefox68 | --- | fixed |
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(1 file)
The prefs for Picture-in-Picture got accidentally bundled into an #ifdef for MOZ_WEBRTC, and so for builds without MOZ_WEBRTC, these prefs aren't set, which causes exceptions to be thrown for things like the context menu.
Assignee | ||
Updated•5 years ago
|
Assignee | ||
Comment 1•5 years ago
|
||
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/45d19d0692b2 Move Picture-in-Picture prefs outside of MOZ_WEBRTC ifdef block. r=jaws
Comment 3•5 years ago
|
||
Backed out 4 changesets (bug 1527925, bug 1545168, bug 1539567) for failing at /actions/test_media.html on a CLOSED TREE.
Backout link: https://hg.mozilla.org/integration/autoland/rev/8515e58392b724460b731fe12881de75a2397c0a
Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&selectedJob=241082928&revision=f5273f8e51966ff5d45588bfcd1826a5642ba8b4
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=241082928&repo=autoland&lineNumber=1347
Log snippet:
01:50:44 INFO - Invoke the 'invoke an action press at index undefined on ['button@id="pictureInPictureToggleButton" node', address: [object HTMLButtonElement], role: pushbutton, address: 0x1a291700]' test { scenario #0: expected 'name changed' event; }
01:50:44 INFO - TEST-PASS | accessible/tests/mochitest/actions/test_media.html | No actions on the accessible for ['button@id="pictureInPictureToggleButton" node', address: [object HTMLButtonElement], role: pushbutton, address: 0x1a291700]
01:50:44 INFO - TEST-PASS | accessible/tests/mochitest/actions/test_media.html | Wrong action name of the accessible for ['button@id="pictureInPictureToggleButton" node', address: [object HTMLButtonElement], role: pushbutton, address: 0x1a291700]
01:50:44 INFO - Buffered messages finished
01:50:44 INFO - TEST-UNEXPECTED-FAIL | accessible/tests/mochitest/actions/test_media.html | Test timed out.
01:50:44 INFO - SimpleTest.ok@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:275:18
01:50:44 INFO - reportError@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:121:22
01:50:44 INFO - TestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:142:7
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - setTimeout handlerTestRunner._checkForHangs@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:163:5
01:50:44 INFO - TestRunner.runTests/<@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:381:20
01:50:44 INFO - promise callbackTestRunner.runTests@chrome://mochikit/content/tests/SimpleTest/TestRunner.js:368:50
01:50:44 INFO - RunSet.runtests@chrome://mochikit/content/tests/SimpleTest/setup.js:201:14
01:50:44 INFO - RunSet.runall@chrome://mochikit/content/tests/SimpleTest/setup.js:180:12
01:50:44 INFO - hookupTests@chrome://mochikit/content/tests/SimpleTest/setup.js:273:12
01:50:44 INFO - parseTestManifest@chrome://mochikit/content/manifestLibrary.js:38:5
01:50:44 INFO - getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:49:11
01:50:44 INFO - EventHandlerNonNullgetTestManifest@chrome://mochikit/content/manifestLibrary.js:45:3
01:50:44 INFO - hookup@chrome://mochikit/content/tests/SimpleTest/setup.js:253:5
01:50:44 INFO - linkAndHookup@chrome://mochikit/content/harness.xul:45:3
01:50:44 INFO - parseTestManifest@chrome://mochikit/content/manifestLibrary.js:38:5
01:50:44 INFO - getTestManifest/req.onload@chrome://mochikit/content/manifestLibrary.js:49:11
01:50:44 INFO - EventHandlerNonNullgetTestManifest@chrome://mochikit/content/manifestLibrary.js:45:3
01:50:44 INFO - getTestList@chrome://mochikit/content/chrome-harness.js:251:3
01:50:44 INFO - loadTests@chrome://mochikit/content/harness.xul:24:3
Assignee | ||
Updated•5 years ago
|
Pushed by mconley@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cf401bd4f303 Move Picture-in-Picture prefs outside of MOZ_WEBRTC ifdef block. r=jaws
Comment 5•5 years ago
|
||
bugherder |
Updated•5 years ago
|
Updated•5 years ago
|
Description
•