1539605 - AppendInt should call directly into the formatter, without going through varargs etc.

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement, P3)

Description

[Nathan Froyd [:froydnj]]

Now that we have a printf implementation that's fully under our control, we should take advantage of it in nsTSubstring by making AppendInt call the formatter directly, rather than requiring parsing a format string, etc. etc. PrintfTarget will need some new (non-virtual) methods like appendIntDec or appendIntHex.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: Bug 1539605 - add fast paths for integer formatting on nsTSubstring; r=erahm

This way we don't have to go through a bunch of printf nonsense, and we
ought to be able to arrive at optimized routines that take advantage of
constant radices, etc.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a5c4f7e6069a
add fast paths for integer formatting on nsTSubstring; r=erahm

Comment 3

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/a5c4f7e6069a