Closed Bug 1539605 Opened 6 months ago Closed 6 months ago

AppendInt should call directly into the formatter, without going through varargs etc.

Categories

(Core :: String, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: froydnj, Assigned: froydnj)

Details

Attachments

(1 file)

Now that we have a printf implementation that's fully under our control, we should take advantage of it in nsTSubstring by making AppendInt call the formatter directly, rather than requiring parsing a format string, etc. etc. PrintfTarget will need some new (non-virtual) methods like appendIntDec or appendIntHex.

This way we don't have to go through a bunch of printf nonsense, and we
ought to be able to arrive at optimized routines that take advantage of
constant radices, etc.

Assignee: nobody → nfroyd
Pushed by nfroyd@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a5c4f7e6069a
add fast paths for integer formatting on nsTSubstring; r=erahm
Status: NEW → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.