Closed
Bug 1539605
Opened 5 years ago
Closed 5 years ago
AppendInt should call directly into the formatter, without going through varargs etc.
Categories
(Core :: XPCOM, enhancement, P3)
Core
XPCOM
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: froydnj, Assigned: froydnj)
Details
Attachments
(1 file)
Now that we have a printf implementation that's fully under our control, we should take advantage of it in nsTSubstring by making AppendInt call the formatter directly, rather than requiring parsing a format string, etc. etc. PrintfTarget will need some new (non-virtual) methods like appendIntDec or appendIntHex.
|
Assignee | |
Comment 1•5 years ago
|
||
This way we don't have to go through a bunch of printf nonsense, and we
ought to be able to arrive at optimized routines that take advantage of
constant radices, etc.
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → nfroyd
Pushed by nfroyd@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/a5c4f7e6069a add fast paths for integer formatting on nsTSubstring; r=erahm
|
||
Comment 3•5 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
||
Updated•3 years ago
|
Component: String → XPCOM
You need to log in
before you can comment on or make changes to this bug.
Description
•