Closed
Bug 1539629
Opened 5 years ago
Closed 5 years ago
Document splitting followup: fix capture infrastructure in multi-document case
Categories
(Core :: Graphics: WebRender, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: alexical, Assigned: alexical)
References
Details
Attachments
(1 file)
Currently we fail an assertion in gpu_cache.rs when trying to capture for multiple documents, because we don't extract_updates inside the loop that iterates over all of the documents.
|
Assignee | |
Comment 1•5 years ago
|
||
We fail the assertion at the beginning of GpuCache::begin_frame
right now because we run the extract_updates call after building
frames for every document. This just moves the extract_updates
work to be per-document.
|
||
Comment 2•5 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:dthayer, could you have a look please?
Flags: needinfo?(dothayer)
Pushed by dothayer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d23cfcd83850 Fix WR capture for multi-document use r=kvark
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in
before you can comment on or make changes to this bug.
Description
•