Closed Bug 1539629 Opened 7 months ago Closed 6 months ago

Document splitting followup: fix capture infrastructure in multi-document case

Categories

(Core :: Graphics: WebRender, enhancement)

Other Branch
enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: dthayer, Assigned: dthayer)

References

(Depends on 1 open bug, Blocks 1 open bug)

Details

Attachments

(1 file)

Currently we fail an assertion in gpu_cache.rs when trying to capture for multiple documents, because we don't extract_updates inside the loop that iterates over all of the documents.

We fail the assertion at the beginning of GpuCache::begin_frame
right now because we run the extract_updates call after building
frames for every document. This just moves the extract_updates
work to be per-document.

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:dthayer, could you have a look please?

Flags: needinfo?(dothayer)
Blocks: 1544508

Landing queued.

Flags: needinfo?(dothayer)
Pushed by dothayer@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d23cfcd83850
Fix WR capture for multi-document use r=kvark
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.