Closed Bug 1539631 Opened 5 months ago Closed 3 months ago

Cancel-task action should not fail if the task isn't running

Categories

(Firefox Build System :: Task Configuration, task, P3)

Tracking

(firefox68 fixed)

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: dustin, Assigned: dustin)

Details

Attachments

(1 file)

https://tools.taskcluster.net/groups/IoQePorDQxqWTb7pqVmVeg/tasks/TlRNNPr3TP-mtuVmqsuaXw/runs/0/logs/public%2Flogs%2Flive.log

[task 2019-03-27T20:30:48.052Z] Traceback (most recent call last):
[task 2019-03-27T20:30:48.052Z]   File "/builds/worker/checkouts/gecko/taskcluster/mach_commands.py", line 261, in action_callback
[task 2019-03-27T20:30:48.052Z]     test=False)
[task 2019-03-27T20:30:48.052Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/registry.py", line 364, in trigger_action_callback
[task 2019-03-27T20:30:48.052Z]     cb(Parameters(**parameters), graph_config, input, task_group_id, task_id)
[task 2019-03-27T20:30:48.052Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/actions/cancel.py", line 27, in cancel_action
[task 2019-03-27T20:30:48.052Z]     cancel_task(task_id, use_proxy=True)
[task 2019-03-27T20:30:48.052Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/util/taskcluster.py", line 222, in cancel_task
[task 2019-03-27T20:30:48.052Z]     _do_request(get_task_url(task_id, use_proxy) + '/cancel', json={})
[task 2019-03-27T20:30:48.053Z]   File "/builds/worker/checkouts/gecko/taskcluster/taskgraph/util/taskcluster.py", line 93, in _do_request
[task 2019-03-27T20:30:48.053Z]     response.raise_for_status()
[task 2019-03-27T20:30:48.053Z]   File "/builds/worker/checkouts/gecko/third_party/python/requests/requests/models.py", line 840, in raise_for_status
[task 2019-03-27T20:30:48.053Z]     raise HTTPError(http_error_msg, response=self)
[task 2019-03-27T20:30:48.053Z] HTTPError: 409 Client Error: Conflict for url: http://taskcluster/api/queue/v1/task/Qjk7dcdERgyTbpB0D6UyTg/cancel

I suspect that tried to cancel a task that wasn't in the right state. We should handle that error gracefully and consider the cancellation action a success.

Priority: -- → P3

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:dustin, could you have a look please?
For more information, please visit auto_nag documentation.

Flags: needinfo?(dustin)
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8c1f903def0c
ignore 409 errors cancelling tasks; r=tomprince
Status: NEW → RESOLVED
Closed: 3 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: needinfo?(dustin)
You need to log in before you can comment on or make changes to this bug.