Closed Bug 1539636 Opened 5 years ago Closed 5 years ago

Inspecting an element with Touch Simulation enabled in RDM triggers click

Categories

(DevTools :: Responsive Design Mode, defect)

Product:
DevTools
Component:
Responsive Design Mode
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED DUPLICATE of bug 1386796

People

(Reporter: Harald, Assigned: bradwerth)

References

Details

(Keywords: regression, Whiteboard: [dt-q])

Reproduced on Nightly/OSX.

What were you doing?

  1. Open RDM and Inspector on https://firefox-devtools-dont-click-this-button.glitch.me/
  2. Make sure to enable touch simulation in RDM
  3. Using the Inspector's Inspect button, inspect the element

What happened?

Click is triggered on the button.

What should have happened?

Just inspection, no click being fired.

Works as expected in Firefox 66 and Chrome. Breaks element in RDM, as inspection changes the UI.

First seen via https://twitter.com/drybones_5/status/1110936717945655298 .

I'll take a look.

Assignee: nobody → bwerth

FWIW, I can't reproduce on Linux Nightly. Maybe this is platform-specific?

I tried inspecting via:

  • right-click + "inspect",
  • left-clicking the picker tool, and then left-clicking the button.
    Neither of those caused the button to be clicked.

Trying on a fresh profile, I also can't see it. Need to dissect what else is going in my default profile.

Found it, Enable Touch Simulation

Thanks, I can reproduce with that. The bug reproduces in Firefox 66 as well, so probably not a regression from recent RDM work.

(I'm guessing comment 0's "Works as expected in Firefox 66" was in a profile where you hadn't turned on touch simulation.)

Severity: blocker → normal
Keywords: regression
Summary: Inspecting an element in RDM triggers click → Inspecting an element with Touch Simulation enabled in RDM triggers click
Version: 67 Branch → unspecified

Regression range:
Last good revision: fe895421dfbe1f1f8f1fc6a39bb20774423a6d74 (2016-08-17)
First bad revision: 97a52326b06a07930216ebefa5af333271578904 (2016-08-18)
Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=fe895421dfbe1f1f8f1fc6a39bb20774423a6d74&tochange=97a52326b06a07930216ebefa5af333271578904

Likely regression from this commit:

https://hg.mozilla.org/mozilla-central/rev/831107a4950a
Benoit Chabod — Bug 1285566 - Create an EmulationActor and use per-tab API for touch simulator, r=jryans

status-firefox66: unaffected → ---
status-firefox67: affected → ---
Blocks: 1285566
Keywords: regression
See Also: → 1386796

Imho a duplicate of bug 1386796. I marked it as see also for now.

Whiteboard: [dt-q]
See Also: → 1409085

Yes this is definitely a duplicate of that one, and not a regression. It's an unfortunate limitation of our touch simulation actor. It might actually not be too bad to fix. I'll try to take a quick look at the code involved in this today and report back any findings.

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE

(In reply to Patrick Brosset <:pbro> from comment #8)

Yes this is definitely a duplicate of that one, and not a regression.

Oops, I transferred regression keyword/bug to that bug before seeing this. Feel free to revert that as-appropriate.)

(I don't understand the "not a regression" classification, though... It went from working-correctly to not-working-correctly, with an identified regression-range, and that sounds like a regression. :))

You need to log in before you can comment on or make changes to this bug.