Closed Bug 1539638 Opened 9 months ago Closed 8 months ago

[wpt-sync] Sync PR 16079 - [LayoutNG] Ignore cached min/max widths tainted by extrinsics.

Categories

(Core :: CSS Parsing and Computation, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16079 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16079
Details from upstream follow.

Morten Stenshorne <mstensho@chromium.org> wrote:

[LayoutNG] Ignore cached min/max widths tainted by extrinsics.

Some properties (e.g. percentage padding) cause the cached min/max
preferred inline sizes to be affected by the extrinsic size calculation.
We store preferred min/max border box sizes. When a shrink-to-fit
container has percentage-based inline padding, the resolved percentage
padding is part of the preferred size. So, what we store is no longer
purely intrinsic in this case, since percentages are resolved against
something on the outside. The values need to be updated if the size of
the containing block changes. Therefore, never re-use a previously
calculated min/max preferred inline size in such cases.

Remove code from NGBlockNode::Layout() which attempted to cope with such
situations by using the legacy layout engine to recalculate min/max
values. This doesn't work, because the legacy layout engine hasn't been
updated with the new containing block size at this point (which are
needed in order to resolve percentages correctly).

Bug: 932979
Change-Id: I884bb2777babe9dae785055bac5029d7ea941a66
Reviewed-on: https://chromium-review.googlesource.com/1538085
WPT-Export-Revision: 91b07fd25a327a681caa7946f766e0cb9331accf

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7d31f9d4b26d
[wpt PR 16079] - [LayoutNG] Ignore cached min/max widths tainted by extrinsics., a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8b1089b0d5a7
[wpt PR 16079] - [LayoutNG] Ignore cached min/max widths tainted by extrinsics., a=testonly
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.