Closed
Bug 1539665
Opened 5 years ago
Closed 5 years ago
Handle the tabbrowser-arrowscrollbox XBL logic from within tabbrowser-tabs
Categories
(Firefox :: Tabbed Browser, task, P1)
Firefox
Tabbed Browser
Tracking
()
RESOLVED
FIXED
Firefox 68
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: bgrins, Assigned: bgrins)
References
Details
Attachments
(2 files)
There's already a tight coupling here (see references to the binding parent at https://searchfox.org/mozilla-central/rev/3d469329a42644b41e66944d8da22d78d8c0f5ec/browser/base/content/tabbrowser.xml#12-69). If we let this element get the normal scrollbox binding, we should be able to add event listeners and override properties from the binding parent (tabbrowser-tabs).
|
Assignee | |
Comment 1•5 years ago
|
||
|
|
Assignee | |
Updated•5 years ago
|
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
|
||
Updated•5 years ago
|
Priority: -- → P1
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/66fa0672d6ea Handle the tabbrowser-arrowscrollbox XBL logic from within tabbrowser-tabs r=dao
|
|
Assignee | |
Comment 3•5 years ago
|
||
It's unused, since _canScrollToElement is overridden right below and doesn't use 'this'.
Pushed by bgrinstead@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/657dd79f0363 Remove arrowScrollbox as 'this' parameter into Array.filter;r=dao
|
||
Comment 5•5 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/66fa0672d6ea
https://hg.mozilla.org/mozilla-central/rev/657dd79f0363
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
|
||
Updated•5 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•