1539665 - Handle the tabbrowser-arrowscrollbox XBL logic from within tabbrowser-tabs

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, task, P1)

Description

[Brian Grinstead [:bgrins]]

There's already a tight coupling here (see references to the binding parent at https://searchfox.org/mozilla-central/rev/3d469329a42644b41e66944d8da22d78d8c0f5ec/browser/base/content/tabbrowser.xml#12-69). If we let this element get the normal scrollbox binding, we should be able to add event listeners and override properties from the binding parent (tabbrowser-tabs).

Comment 1

[Brian Grinstead [:bgrins]]

Attachment: Bug 1539665 - Handle the tabbrowser-arrowscrollbox XBL logic from within tabbrowser-tabs

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/66fa0672d6ea
Handle the tabbrowser-arrowscrollbox XBL logic from within tabbrowser-tabs r=dao

Comment 3

[Brian Grinstead [:bgrins]]

Attachment: Bug 1539665 - Remove arrowScrollbox as 'this' parameter into Array.filter;r=dao

It's unused, since _canScrollToElement is overridden right below and doesn't use 'this'.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/657dd79f0363
Remove arrowScrollbox as 'this' parameter into Array.filter;r=dao

Comment 5

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/66fa0672d6ea
https://hg.mozilla.org/mozilla-central/rev/657dd79f0363