Closed Bug 1539675 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 16051 - Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic

Categories

(Testing :: web-platform-tests, enhancement, P4)

Product:
Testing
Component:
web-platform-tests
Type:
enhancement

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16051 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16051
Details from upstream follow.

Hajime Hoshi <hajimehoshi@chromium.org> wrote:

Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic

This test passes as some events like click or mousedown for the first
click are missed at the second PerformanceObserver in startObserver.
This CL makes sure that the first PerformanceObserver does not proceed
until the first click event happens.

Actually we found the test failed when we use a different task runner is
used for WidgetInputHandler (https://chromium-review.googlesource.com/c/chromium/src/+/1530492/4).

Bug: 872081
Change-Id: I8d8fe187b8053140f40ae9cf08737fcf7b64233c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538136
Commit-Queue: Nicolás Peña Moreno \<npm@chromium.org>
Reviewed-by: Nicolás Peña Moreno \<npm@chromium.org>
Reviewed-by: Alexander Timin \<altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644321}

Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d56536bd8de9
[wpt PR 16051] - Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic, a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7b8f7a84aefb
[wpt PR 16051] - Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic, a=testonly

https://hg.mozilla.org/mozilla-central/rev/d56536bd8de9
https://hg.mozilla.org/mozilla-central/rev/7b8f7a84aefb

Status: NEW → RESOLVED
Closed: 5 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.