1539699 - [about:addons] identify recommended extensions in about:addons

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, enhancement, P2)

Description

[David Durst [:ddurst]]

We want to be able to show the user which extensions they've installed that are recommended. This would be in the detail and list views.

This is intended to go along with discopane changes, but filed separately because it may be easier to deal with this when dealing with the rest of the HTML changes.

Comment 1

[David Durst [:ddurst]]

Release Note Request (optional, but appreciated)
[Why is this notable]: Users will see a visual indication on about:addons denoting which extensions they've installed that are recommended.
[Affects Firefox for Android]: n/a
[Suggested wording]: Find high-quality, secure extensions via the Recommended Extensions program. Look for these vetted extensions in about:addons.
[Links (documentation, blog post, etc)]: TBD

Comment 2

[Julien Cristau [:jcristau]]

Looks like this and bug 1540173 have the same release notes request. Any preference which bug to associate it with?

Comment 3

[David Durst [:ddurst]]

This is because the Suggested wording is the same for both. Atsay -- this feature actually applies across a few things (this, 1540173, etc). But since there's no one place, this could be about discopane or it could be about the about:addons change.

Comment 4

[Amy Tsay [:amyt]]

The relnotes apply to both, but if we need to choose one let's associate it with 1540173. Thanks!

Comment 5

[Julien Cristau [:jcristau]]

Thanks, I'll use that.

Comment 6

[Mark Striemer [:mstriemer]]

Attachment: Bug 1539699 - Show a recommended badge for recommended add-ons (HTML)

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/02ee2cdf02b3
Show a recommended badge for recommended add-ons (HTML) r=mixedpuppy

Comment 8

[Mark Striemer [:mstriemer]]

Comment on attachment 9071733 [details]
Bug 1539699 - Show a recommended badge for recommended add-ons (HTML)

Beta/Release Uplift Approval Request

• User impact if declined: Recommended add-ons installed from AMO will not be shown as recommended in Firefox.
• Is this code covered by automated tests?: Yes
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: Bug 1540253
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Along with bug 1540253: these are fairly simple and small changes with test coverage.
• String changes made/needed: No

Comment 9

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/02ee2cdf02b3

Comment 10

[Julien Cristau [:jcristau]]

Rob asked to hold off on this uplift for now. lmk when this is good to go.

Comment 11

[Rob Wu [:robwu]]

I fixes the (innocent) regressions, and it is ready to uplift:

1. bug 1540253 (already mentioned in uplift request)
2. bug 1539699 (this bug)
3. bug 1559112 (remove warning message; verified by running the new test and confirming that there is no error message)
4. bug 1559131 (skip test when MOZ_REQUIRE_SIGNING=1)

The last two patches are new.

Comment 12

[Rob Wu [:robwu]]

Mark posted an updated uplift request with all bugs that I mentioned in comment 11 in https://bugzilla.mozilla.org/show_bug.cgi?id=1540253#c8

Comment 13

[Julien Cristau [:jcristau]]

Comment on attachment 9071733 [details]
Bug 1539699 - Show a recommended badge for recommended add-ons (HTML)

approved for 68.0b11

Comment 14

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/releases/mozilla-beta/rev/255b632c9f90

Comment 15

[Alex Cornestean]

This issue is Verified as Fixed on Firefox 69.0a1 (20190617214029) under Windows 10 Pro 64-bit and MacOS High Sierra 10.13.6.

To verify the validity of the fix, the following prefs have been modified as follows:

• xpinstall.signatures.required – false
• xpinstall.signatures.dev-root – true
• extensions.getAddons.discovery.api_url - https://services.addons-dev.allizom.org/api/v4/discovery/?lang=%LOCALE%

Furthermore, for test purposes, several add-ons from dev have been marked with the recommended tag and pushed to the list of recommended addons displayed on about:addons.

When the above conditions are met, the ‘Recommended’ badge and the ‘Recommended’ string upon hovering over the badge are displayed.

However, while validating the fix, one potential issue has been encountered. We observed that the badge and string for recommended themes which are installed, are not displayed. For further details, please refer to: https://bugzilla.mozilla.org/show_bug.cgi?id=1559895.