1539720 - caret clamping in scrolled elements is broken

Status: RESOLVED FIXED

(Core :: Layout, defect, P3)

Description

[Cameron McCormack (:heycam)]

Bug 335560 added clamping to the caret position so that if you are scrolled to the edge of an element, and the caret is inside that element but outside of the visual overflow rect of the scrolled element, the caret is clamped to be just inside the rect so that it will still be visible if the scroll frame is clipped.

This regressed some time here in March 2015:

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=c5b90c003be8&tochange=993eb76a8bd6

(Aside: why isn't that using the scrollable overflow rect instead of visual overflow?)

Comment 1

[Cameron McCormack (:heycam)]

Attachment: test

This is the test I was using. Click on an "x" and press End to move to the end of the line. The caret isn't visible.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1539720 - Fix caret overflow adjustment computations. r=masayuki

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/970525aa04f1
Fix caret overflow adjustment computations. r=masayuki

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a6a541637edd
Fix test_reftests_with_caret.html failures. r=emilio CLOSED TREE

Comment 6

[Cosmin Sabou [:CosminS]]

Backed out for causing caret related failures.

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&fromchange=970525aa04f13d2a80e78a79b98c88c3a6838be3&searchStr=plain&selectedTaskRun=fT4cSGFwQ9a9RBlgTSz1MQ.0

Failure logs from first land:

• https://treeherder.mozilla.org/logviewer?job_id=426320948&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=426320732&repo=autoland

Failures after the attempted fix:

• https://treeherder.mozilla.org/logviewer?job_id=426325526&repo=autoland
• https://treeherder.mozilla.org/logviewer?job_id=426325376&repo=autoland

Backout link: https://hg.mozilla.org/integration/autoland/rev/a6c91cd0d909c83e7f1f4d8c3b79b31d5de33825

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5841f85bd162
Fix caret overflow adjustment computations. r=masayuki

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a20acf7c387
Annotate new reftests as failing with drawSnapshot.

Comment 9

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/5841f85bd162
https://hg.mozilla.org/mozilla-central/rev/4a20acf7c387