1539739 - armv7 build fails with: error: field 'ufp' has incomplete type 'user_vfp'

Status: RESOLVED DUPLICATE of bug 1526653

(Core :: JavaScript: WebAssembly, defect)

Description

[Guillaume GARDET]

Attachment: armv7 Firefox 66.0 build log

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/73.0.3683.86 Safari/537.36

Steps to reproduce:

While trying to build Firefox 66.0 for armv7l, the build fails because of "field 'ufp' has incomplete type 'user_vfp'" error.

Actual results:

Build log:
[ 1116s] 13:17.43 In file included from /home/abuild/rpmbuild/BUILD/obj/js/src/wasm/Unified_cpp_js_src_wasm2.cpp:29:
[ 1116s] 13:17.43 /home/abuild/rpmbuild/BUILD/firefox-66.0/js/src/wasm/WasmSignalHandlers.cpp:520:19: error: field 'ufp' has incomplete type 'user_vfp'
[ 1116s] 13:17.43 struct user_vfp ufp;
[ 1116s] 13:17.43 ^~~
[ 1116s] 13:17.44 /home/abuild/rpmbuild/BUILD/firefox-66.0/js/src/wasm/WasmSignalHandlers.cpp:520:10: note: forward declaration of 'struct user_vfp'
[ 1116s] 13:17.44 struct user_vfp ufp;
[ 1116s] 13:17.44 ^~~~~~~~
[ 1116s] 13:17.45 /home/abuild/rpmbuild/BUILD/firefox-66.0/js/src/wasm/WasmSignalHandlers.cpp:521:23: error: field 'ufp_exc' has incomplete type 'user_vfp_exc'
[ 1116s] 13:17.45 struct user_vfp_exc ufp_exc;
[ 1116s] 13:17.46 ^~~~~~~
[ 1116s] 13:17.48 /home/abuild/rpmbuild/BUILD/firefox-66.0/js/src/wasm/WasmSignalHandlers.cpp:521:10: note: forward declaration of 'struct user_vfp_exc'
[ 1116s] 13:17.48 struct user_vfp_exc ufp_exc;
[ 1116s] 13:17.48 ^~~~~~~~~~~~

Expected results:

Build should succeed.

Comment 1

[Guillaume GARDET]

The file /usr/include/sys/user.h has no information about 'user_vfp' or 'user_vfp_exc' structs.

See: https://sourceware.org/git/gitweb.cgi?p=glibc.git;a=blob;f=sysdeps/unix/sysv/linux/arm/sys/user.h;h=aae8a99e56567cbc7e306d8f918a629ab3b60d9a;hb=56c86f5dd516284558e106d04b92875d5b623b7a

Comment 2

[tt_1]

I think this is duplicate of #1526653

Comment 3

[Lars T Hansen [:lth]]

Right you are.

Comment 4

[Lars T Hansen [:lth]]

Guillaume, see comment at https://searchfox.org/mozilla-central/source/js/src/wasm/WasmSignalHandlers.cpp#232 for a workaround.