1539753 - The eslintignore config used in autoland test is inconsistent with the ones in repo and try server

Status: RESOLVED INVALID

(Developer Infrastructure :: Lint and Formatting, defect)

Description

[violet.bugreport]

The eslint testing in autoland doesn't honor the ignore rules defined in the .eslintignore file in mozilla-central repo. It also contradicts to the try server, since try server honors these ignore rules.

A specific example:

.eslintignore file explicitly excludes the directory dom/svg/**: https://searchfox.org/mozilla-central/source/.eslintignore#194

I have a patch with a linting problem (forgetting a let before using variable), try server didn't report eslint error: https://treeherder.mozilla.org/#/jobs?repo=try&revision=cf04346e25ed8b5651fd3e6ce035c8c29a3516f3

But when I landed it, the autoland test reported the eslint error: https://bugzilla.mozilla.org/show_bug.cgi?id=1512745#c12

So it seems the autoland test doesn't look at the .eslintignore rules. It's quite confusing, because I'd expect try server behaves the same as autoland tests.

Comment 1

[violet.bugreport]

This: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ab36a98a44257d416f337e1a5fe650f47291ea13 is a simple check to confirm that try server does report eslint problem. It didn't report in the above case just because it honors the ignore rules in .eslintignore.

Comment 2

[Mark Banner (:standard8)]

Unfortunately this is a case of patches clashing when landing on autoland:

https://hg.mozilla.org/integration/autoland/pushloghtml/?fromchange=152457c26513&tochange=c045dd97faf2

Thu Mar 28 06:56:48 2019 +0000 c045dd97faf2 Brindusan Cristian — Backed out changeset 062344ad3eea (bug 1512745) for ESlint failure at test_pairParsing.html:31:5.
Thu Mar 28 06:39:24 2019 +0000 062344ad3eea violet — Bug 1512745 - Allow leading and trailing spaces for pairs as well r=longsonr
Thu Mar 28 06:34:36 2019 +0000 772847bbb314 championshuttler — Bug 1508987 - Enable ESLint for dom/svg/ (Manual Changes). r=jwatt
                               69b00bf72f9e championshuttler — Bug 1508987 - Enable ESLint for dom/svg/ (Automatic Changes). r=jwatt

Your patch landed immediately after the bug enabling ESLint for dom/svg, and hence this is why it was disabled for mozilla-central etc as it hadn't had time to be merged.

We can't do much about it since that's how the integration system works - there's always a risk that some patch could land on autoland just before another patch and cause conflicts.