1539780 - Maybe merge EXPOSE_INTL_API and ENABLE_INTL_API?

Status: RESOLVED FIXED

(Core :: JavaScript: Internationalization API, enhancement, P3)

Description

[André Bargull [:anba]]

It looks like the configuration option --with-intl-api=build isn't really tested anymore, because lots of places are using ENABLE_INTL_API and EXPOSE_INTL_API interchangeably. (It was probably me how was using ENABLE_INTL_API instead of EXPOSE_INTL_API. Whoops!)

Comment 1

[Jeff Walden [:Waldo]]

Yeah, the point of build was to compile and test the Intl code before we decided to ship it, it has no long-term value. Cleaning this up is not particularly important in any timeframe, tho.

Comment 2

[André Bargull [:anba]]

Attachment: Bug 1539780: Remove "--with-intl-api=build" build config option. r=jwalden!

There are about the same number of occurrences of "ENABLE_INTL_API" and "EXPOSE_INTL_API"
in the tree, so preferring one over the other doesn't lead to fewer changes. Therefore
I went with "ENABLE_INTL_API", because "ENABLE_" (resp. "MOZ_ENABLE") is already used as
the prefix for other preprocessor ifdef's.

Comment 3

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=a5f213d33a4b51f13e2e665b0134cb5529727a4c

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5967a3947ad0
Remove "--with-intl-api=build" build config option. r=jwalden

Comment 5

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/5967a3947ad0

Comment 6

[BugBot [:suhaib / :marco/ :calixte]]

Since the status are different for nightly and release, what's the status for beta?
For more information, please visit auto_nag documentation.