1539796 - Perma /builds/worker/workspace/build/src/dom/media/ipc/RDDProcessHost.cpp:15:12: fatal error: 'mozilla/Sandbox.h' file not found

Status: RESOLVED FIXED

(Core :: Security: Process Sandboxing, defect, P1)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: opoprus [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=236572619&repo=mozilla-central

https://queue.taskcluster.net/v1/task/LwrOiaIFSye6FN6o4uS6hw/runs/0/artifacts/public/logs/live_backing.log

[task 2019-03-28T10:39:43.192Z] 10:39:43 INFO - /builds/worker/workspace/build/src/dom/media/ipc/RDDProcessHost.cpp:15:12: fatal error: 'mozilla/Sandbox.h' file not found
[task 2019-03-28T10:39:43.192Z] 10:39:43 INFO - # include "mozilla/Sandbox.h"
[task 2019-03-28T10:39:43.193Z] 10:39:43 INFO - ^~~~~~~~~~~~~~~~~~~
[task 2019-03-28T10:39:43.193Z] 10:39:43 INFO - 1 error generated.
[task 2019-03-28T10:39:43.193Z] 10:39:43 INFO - /builds/worker/workspace/build/src/config/rules.mk:805: recipe for target 'RDDProcessHost.o' failed
[task 2019-03-28T10:39:43.194Z] 10:39:43 ERROR - make[4]: *** [RDDProcessHost.o] Error 1
[task 2019-03-28T10:39:43.194Z] 10:39:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/ipc'
[task 2019-03-28T10:39:43.194Z] 10:39:43 INFO - make[4]: *** Waiting for unfinished jobs....
[task 2019-03-28T10:39:43.201Z] 10:39:43 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/mediasource'
[task 2019-03-28T10:39:43.201Z] 10:39:43 INFO - mkdir -p '.deps/'
[task 2019-03-28T10:39:43.201Z] 10:39:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/mediasource'
[task 2019-03-28T10:39:43.203Z] 10:39:43 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/mediasource'
[task 2019-03-28T10:39:43.203Z] 10:39:43 INFO - dom/media/mediasource/Unified_cpp_media_mediasource0.o
[task 2019-03-28T10:39:43.203Z] 10:39:43 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/mediasource'
[task 2019-03-28T10:39:44.829Z] 10:39:44 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/html'
[task 2019-03-28T10:39:44.829Z] 10:39:44 INFO - /builds/worker/workspace/build/src/clang/bin/clang++ -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk --target=x86_64-darwin11 -o Unified_cpp_dom_html4.o -c -flto=thin -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/html -I/builds/worker/workspace/build/src/obj-firefox/dom/html -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/caps -I/builds/worker/workspace/build/src/docshell/base -I/builds/worker/workspace/build/src/dom/base -I/builds/worker/workspace/build/src/dom/canvas -I/builds/worker/workspace/build/src/dom/html/input -I/builds/worker/workspace/build/src/dom/media -I/builds/worker/workspace/build/src/dom/security -I/builds/worker/workspace/build/src/dom/xbl -I/builds/worker/workspace/build/src/dom/xul -I/builds/worker/workspace/build/src/image -I/builds/worker/workspace/build/src/layout/forms -I/builds/worker/workspace/build/src/layout/generic -I/builds/worker/workspace/build/src/layout/style -I/builds/worker/workspace/build/src/layout/tables -I/builds/worker/workspace/build/src/layout/xul -I/builds/worker/workspace/build/src/netwerk/base -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Wno-error=shadow @/builds/worker/workspace/build/src/obj-firefox/code_coverage_cflags -MD -MP -MF .deps/Unified_cpp_dom_html4.o.pp /builds/worker/workspace/build/src/obj-firefox/dom/html/Unified_cpp_dom_html4.cpp
[task 2019-03-28T10:39:44.829Z] 10:39:44 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/html'
[task 2019-03-28T10:39:44.831Z] 10:39:44 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/mediasource/gtest'
[task 2019-03-28T10:39:44.832Z] 10:39:44 INFO - mkdir -p '.deps/'
[task 2019-03-28T10:39:44.832Z] 10:39:44 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/mediasource/gtest'
[task 2019-03-28T10:39:44.836Z] 10:39:44 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/mediasource/gtest'
[task 2019-03-28T10:39:44.836Z] 10:39:44 INFO - dom/media/mediasource/gtest/Unified_cpp_mediasource_gtest0.o
[task 2019-03-28T10:39:44.837Z] 10:39:44 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/mediasource/gtest'
[task 2019-03-28T10:39:46.764Z] 10:39:46 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/ipc'
[task 2019-03-28T10:39:46.764Z] 10:39:46 INFO - /builds/worker/workspace/build/src/clang/bin/clang++ -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk --target=x86_64-darwin11 -o RDDParent.o -c -flto=thin -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZ_HAS_MOZGLUE -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/builds/worker/workspace/build/src/dom/media/ipc -I/builds/worker/workspace/build/src/obj-firefox/dom/media/ipc -I/builds/worker/workspace/build/src/xpcom/base -I/builds/worker/workspace/build/src/obj-firefox/ipc/ipdl/_ipdlheaders -I/builds/worker/workspace/build/src/ipc/chromium/src -I/builds/worker/workspace/build/src/ipc/glue -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables @/builds/worker/workspace/build/src/obj-firefox/code_coverage_cflags -MD -MP -MF .deps/RDDParent.o.pp /builds/worker/workspace/build/src/dom/media/ipc/RDDParent.cpp
[task 2019-03-28T10:39:46.765Z] 10:39:46 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/ipc'
[task 2019-03-28T10:39:46.766Z] 10:39:46 INFO - /builds/worker/workspace/build/src/config/recurse.mk:74: recipe for target 'dom/media/ipc/target' failed
[task 2019-03-28T10:39:46.767Z] 10:39:46 ERROR - make[3]: *** [dom/media/ipc/target] Error 2
[task 2019-03-28T10:39:46.767Z] 10:39:46 INFO - make[3]: *** Waiting for unfinished jobs....
[task 2019-03-28T10:39:46.768Z] 10:39:46 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/gmp'
[task 2019-03-28T10:39:46.768Z] 10:39:46 INFO - dom/media/gmp/Unified_cpp_dom_media_gmp1.o
[task 2019-03-28T10:39:46.768Z] 10:39:46 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/dom/media/gmp'
[task 2019-03-28T10:39:47.026Z] 10:39:47 INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/dom/html'

Comment 1

[Haik Aftandilian [:haik]]

The problem here is a missing defined(MOZ_SANDBOX) check. I'll post a patch once my build completes. (nsMacUtilsImpl.h appears to not be needed so I'll remove that.

$ hg diff -c .
diff --git a/dom/media/ipc/RDDProcessHost.cpp b/dom/media/ipc/RDDProcessHost.cpp
--- a/dom/media/ipc/RDDProcessHost.cpp
+++ b/dom/media/ipc/RDDProcessHost.cpp
@@ -6,19 +6,18 @@
 #include "RDDProcessHost.h"
 
 #include "chrome/common/process_watcher.h"
 #include "mozilla/Preferences.h"
 #include "mozilla/StaticPrefs.h"
 
 #include "RDDChild.h"
 
-#if defined(XP_MACOSX)
+#if defined(XP_MACOSX) && defined(MOZ_SANDBOX)
 #  include "mozilla/Sandbox.h"
-#  include "nsMacUtilsImpl.h"
 #endif
 
 namespace mozilla {
 
 using namespace ipc;
 
 #if defined(XP_MACOSX) && defined(MOZ_SANDBOX)
 bool RDDProcessHost::sLaunchWithMacSandbox = false;

Comment 2

[Haik Aftandilian [:haik]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=314755fb90e231022974dc9cd39f19aaa4daebd2

Comment 3

[Haik Aftandilian [:haik]]

Attachment: Bug 1539796 - Ccov build: fatal error: 'mozilla/Sandbox.h' file not found r?Alex_Gaynor

Add missing MOZ_SANDBOX preprocessor check before including Sandbox.h to fix the code coverage build.

Remove unused nsMacUtilsImpl.h #include.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d33c1566c2d9
Ccov build: fatal error: 'mozilla/Sandbox.h' file not found r=Alex_Gaynor

Comment 5

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/d33c1566c2d9

Comment 6

[Intermittent Failures Robot]

4 failures in 3910 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-central: 4

Platform breakdown:

• osx-cross-ccov: 4

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1539796&startday=2019-03-25&endday=2019-03-31&tree=all