Closed Bug 1539816 Opened 8 months ago Closed 6 months ago

With autocomplete pref turned off, the autocomplete acts weirdly when invoked with Ctrl + Space

Categories

(DevTools :: Console, defect, P2)

66 Branch
defect

Tracking

(firefox69 fixed)

RESOLVED FIXED
Firefox 69
Tracking Status
firefox69 --- fixed

People

(Reporter: nchevobbe, Assigned: dhruvibutti9477)

References

(Blocks 1 open bug)

Details

Attachments

(1 obsolete file)

Steps to reproduce

  1. In about config, set devtools.webconsole.input.autocomplete to false
  2. Open the console
  3. Type wi
  4. Hit <kbd>Ctrl+Space</kbd>
  5. A popup containing window, with, Window appears, with window selected.
  6. Type n

Expected results

The popup is filtered and only contains window and Window

Actual results

The popup isn't filtered. Hitting Ctrl+Space again doesn't filter it either.

Dhruvi, would you like to take a look at this issue? No pressure, it's totally okay if you don't want to or don't have the time to :)

Flags: needinfo?(dhruvibutti9477)

Would love to take this up! Please assign this to me.
Thank you.
Dhruvi

Flags: needinfo?(dhruvibutti9477)

Thanks a lot Dhruvi, it's yours :)
I think we are too aggressive on the input handler function, we should check if the autocomplete popup is displayed and behave differently.

Assignee: nobody → dhruvibutti9477
Status: NEW → ASSIGNED

Hey! I tried debugging various autocomplete actions using browser toolbox but failed to find something that could create this issue. I realized that we need some mechanism which could update the input of the autocomplete popup as the popup is updated if we press ctrl+space again. Would you please help me with this?
Thank you!
Dhruvi.

Attachment #9060304 - Attachment description: Bug 1539816 - With autocomplete pref turned off, the autocomplete acts weirdly when invoked with Ctrl + Space. r=nchevobbe. → Bug 1539816 - Always filter the autocomplete popup items if the popup was opened. r=nchevobbe.
Pushed by nchevobbe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1df06ef18140
Always filter the autocomplete popup items if the popup was opened. .
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 69
Blocks: 1557622
Attachment #9060304 - Attachment is obsolete: true
You need to log in before you can comment on or make changes to this bug.