1539816 - With autocomplete pref turned off, the autocomplete acts weirdly when invoked with Ctrl + Space

Status: RESOLVED FIXED

(DevTools :: Console, defect, P2)

Description

[Nicolas Chevobbe [:nchevobbe]]

Steps to reproduce

1. In about config, set devtools.webconsole.input.autocomplete to false
2. Open the console
3. Type wi
4. Hit <kbd>Ctrl+Space</kbd>
5. A popup containing window, with, Window appears, with window selected.
6. Type n

Expected results

The popup is filtered and only contains window and Window

Actual results

The popup isn't filtered. Hitting Ctrl+Space again doesn't filter it either.

Comment 1

[Nicolas Chevobbe [:nchevobbe]]

Dhruvi, would you like to take a look at this issue? No pressure, it's totally okay if you don't want to or don't have the time to :)

Comment 2

[Dhruvi Butti]

Would love to take this up! Please assign this to me.
Thank you.
Dhruvi

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Thanks a lot Dhruvi, it's yours :)
I think we are too aggressive on the input handler function, we should check if the autocomplete popup is displayed and behave differently.

Comment 4

[Dhruvi Butti]

Hey! I tried debugging various autocomplete actions using browser toolbox but failed to find something that could create this issue. I realized that we need some mechanism which could update the input of the autocomplete popup as the popup is updated if we press ctrl+space again. Would you please help me with this?
Thank you!
Dhruvi.

Comment 5

[Dhruvi Butti]

Attachment: Bug 1539816 - Always filter the autocomplete popup items if the popup was opened. r=nchevobbe.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1df06ef18140
Always filter the autocomplete popup items if the popup was opened. .

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/1df06ef18140