Closed Bug 1539817 Opened 9 months ago Closed 8 months ago

Uplift Debugger Backend improvements

Categories

(DevTools :: Debugger, enhancement, P1)

enhancement

Tracking

(firefox67 fixed)

RESOLVED FIXED
Tracking Status
firefox67 --- fixed

People

(Reporter: jlast, Assigned: jlast)

References

Details

Attachments

(1 file)

We are releasing two significant new features to the Debugger (Column Breakpoints, Worker Debugging). It would be nice to uplift several backend improvements that improve the stability.

1537657: Paused workers stay as zombies on page refresh
1536618: Unexpected "query object's 'source' property is not undefined nor a Debugger.Source
1535071: Tab crash when reporting exception in worker after refreshing page a ton

No longer depends on: 1539813
Priority: -- → P1
Attached patch uplift-b-1.patchSplinter Review

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1538164
  • User impact if declined: There will be a couple of issues for the debugger:
  1. setting breakpoints will be slower
  2. worker debugging will be less stable
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): it only affects the debugger and the fixes have been tested on nightly
  • String changes made/needed:
Assignee: nobody → jlaster
Attachment #9054895 - Flags: approval-mozilla-beta?

Logan can you verify this patch?

Flags: needinfo?(lsmyth)
Flags: needinfo?(lsmyth)
Attachment #9054895 - Flags: review+
Comment on attachment 9054895 [details] [diff] [review]
uplift-b-1.patch

Improvements to the stability and responsiveness of the debugger, uplift approved for 67 beta 8, thanks.
Attachment #9054895 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Status: NEW → RESOLVED
Closed: 8 months ago
Depends on: 1536201, 1535071, 1536618
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.