Closed Bug 1539853 Opened 5 months ago Closed 5 months ago

Investigate why aPrincipal might be null within SpeculativeConnectInternal

Categories

(Core :: DOM: Security, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: ckerschb, Assigned: sstreich, NeedInfo)

References

Details

(Whiteboard: [domsecurity-active])

Attachments

(1 file)

Within Bug 1537883 we identified that aPrincipal might be null within SpeculativeConnectInternal. We need to figure out what that happens and remove the 'silent' fail which we added within Bug 1537883.

No longer depends on: 1537883

Just chatted with Valentin, what we should do is the following

  • throw an exception in case aPrincipal is null, and
  • update callsites to handle the exception
Assignee: nobody → streich.mobile
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [domsecurity-active]
Keywords: checkin-needed

Are there any plans on figuring out why aPrincipal would be null in those cases?
I would seem to me that a null window.gBrowser.contentPrincipal could cause issues in some other cases, not only when calling SpeculativeConnect.

Flags: needinfo?(streich.mobile)

Pushed by nbeleuzu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9a658132a7fc
Throw Exceptions on null Principal within SpeculativeConnectInternal and Handle on Callsite r=ckerschb,Gijs

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.