1539853 - Investigate why aPrincipal might be null within SpeculativeConnectInternal

Status: RESOLVED FIXED

(Core :: DOM: Security, enhancement, P1)

Description

[Christoph Kerschbaumer [:ckerschb]]

Within Bug 1537883 we identified that aPrincipal might be null within SpeculativeConnectInternal. We need to figure out what that happens and remove the 'silent' fail which we added within Bug 1537883.

Comment 1

[Christoph Kerschbaumer [:ckerschb]]

Just chatted with Valentin, what we should do is the following

• throw an exception in case aPrincipal is null, and
• update callsites to handle the exception

Comment 2

[Sebastian Streich [:sstreich]]

Attachment: Bug 1539853 - Throw Exceptions on null Principal within SpeculativeConnectInternal and Handle on Callsite r=ckerschb

---

++Linting

Comment 3

[Valentin Gosu [:valentin] (he/him)]

Are there any plans on figuring out why aPrincipal would be null in those cases?
I would seem to me that a null window.gBrowser.contentPrincipal could cause issues in some other cases, not only when calling SpeculativeConnect.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9a658132a7fc
Throw Exceptions on null Principal within SpeculativeConnectInternal and Handle on Callsite r=ckerschb,Gijs

Comment 5

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/9a658132a7fc