[wpt-sync] Sync PR 16090 - Revert "Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic"

RESOLVED FIXED in Firefox 68

Status

enhancement
P4
normal
RESOLVED FIXED
5 months ago
4 months ago

People

(Reporter: wptsync, Unassigned)

Tracking

unspecified
mozilla68
Points:
---

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [wptsync downstream], )

Sync web-platform-tests PR 16090 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16090
Details from upstream follow.

Peter Kasting <pkasting@chromium.org> wrote:

Revert "Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic"

This reverts commit 250c950a568a7614d72b4fa319d86cf2d9b46cf0.

Reason for revert: Timing out on all bots: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=external/wpt/event-timing/event-timing-onloadthenobserve.html&testType=webkit_layout_tests

Original change's description:

Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic

This test passes as some events like click or mousedown for the first
click are missed at the second PerformanceObserver in startObserver.
This CL makes sure that the first PerformanceObserver does not proceed
until the first click event happens.

Actually we found the test failed when we use a different task runner is
used for WidgetInputHandler (https://chromium-review.googlesource.com/c/chromium/src/+/1530492/4).

Bug: 872081
Change-Id: I8d8fe187b8053140f40ae9cf08737fcf7b64233c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1538136
Commit-Queue: Nicolás Peña Moreno \<npm@chromium.org>
Reviewed-by: Nicolás Peña Moreno \<npm@chromium.org>
Reviewed-by: Alexander Timin \<altimin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644321}

TBR=hajimehoshi@chromium.org,altimin@chromium.org,npm@chromium.org

Change-Id: Ibb4e463906f5b8040e96c7e008e999c638630e79
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 872081
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540085
Reviewed-by: Peter Kasting \<pkasting@chromium.org>
Commit-Queue: Peter Kasting \<pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644443}

Whiteboard: [wptsync downstream] → [wptsync downstream error]
Whiteboard: [wptsync downstream error] → [wptsync downstream]
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e6a1a9e8b99
[wpt PR 16090] - Revert "Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic", a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/179f3521ae43
[wpt PR 16090] - Revert "Fix external/wpt/event-timing/event-timing-onloadobserve.html to be more deterministic", a=testonly
Status: NEW → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.