1539884 - Mark EventDispatcher::Dispatch as MOZ_CAN_RUN_SCRIPT

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement, P2)

Description

[Boris Zbarsky [:bzbarsky]]

Since it clearly can.

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 1: Mark Document::DispatchContentLoadedEvents as CAN_RUN_SCRIPT r=masayuki

Comment 2

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 2: Mark PostMessageEvent::Dispatch as CAN_RUN_SCRIPT r=masayuki

Depends on D133751

Comment 3

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 3: Mark VisualViewport::Fire*Event as CAN_RUN_SCRIPT r=masayuki

Depends on D133752

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aa6dfd520383
Part 1: Mark Document::DispatchContentLoadedEvents as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/e1530114beba
Part 2: Mark PostMessageEvent::Dispatch as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/d80ea806fda4
Part 3: Mark VisualViewport::Fire*Event as CAN_RUN_SCRIPT r=masayuki

Comment 5

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 4: Mark nsContentUtils::MaybeFireNodeRemoved as CAN_RUN_SCRIPT r=masayuki

Comment 6

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 4: Mark nsContentUtils::MaybeFireNodeRemoved as CAN_RUN_SCRIPT r=masayuki

Comment 7

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 5: Mark Focus*Event::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki

Depends on D133914

Comment 8

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 6: Mark nsGlobalWindowInner::FireFrameLoadEvent as CAN_RUN_SCRIPT r=masayuki

Depends on D133915

Comment 9

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 7: Mark nsIEventListenerService::getEventTargetChainFor as can_run_script r=masayuki

Depends on D133917

Comment 10

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 8: Mark EventStateManager::Send[Legacy]Event as CAN_RUN_SCRIPT r=masayuki

Depends on D133918

Comment 11

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 9: Mark EventStateManager::PostHandleKeyboardEvent as CAN_RUN_SCRIPT r=masayuki

Depends on D133919

Comment 12

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 10: Mark EventStageManager::DispatchMouseOrPointerEvent as CAN_RUN_SCRIPT r=masayuki

Depends on D133920

Comment 13

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 11: Mark HTMLFormElement::Reset as CAN_RUN_SCRIPT r=masayuki

Depends on D133921

Comment 14

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/aa6dfd520383
https://hg.mozilla.org/mozilla-central/rev/e1530114beba
https://hg.mozilla.org/mozilla-central/rev/d80ea806fda4

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/57068a40f3c9
Part 4: Mark nsContentUtils::MaybeFireNodeRemoved as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ca7c808621d6
Part 5: Mark Focus*Event::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/3d3019f61b5a
Part 6: Mark nsGlobalWindowInner::FireFrameLoadEvent as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ca21c5838f37
Part 7: Mark nsIEventListenerService::getEventTargetChainFor as can_run_script r=masayuki
https://hg.mozilla.org/integration/autoland/rev/a8cfa2201751
Part 8: Mark EventStateManager::Send[Legacy]Event as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/de9e2829d42a
Part 9: Mark EventStateManager::PostHandleKeyboardEvent as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/15d728ef97ca
Part 10: Mark EventStageManager::DispatchMouseOrPointerEvent as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ad65ce9208ce
Part 11: Mark HTMLFormElement::Reset as CAN_RUN_SCRIPT r=masayuki

Comment 16

[Atila Butkovits]

Backed out for causing build bustages at Document.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/792c9fbceb7170c1c00d8bed57a2c3d2cf6d1913

Push with failures: https://treeherder.mozilla.org/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception%2Cretry%2Cusercancel&revision=ad65ce9208ce760d0e7de80c9fb9cd3eb40e1152&selectedTaskRun=YXOqekLATOui4W1eYwoWsQ.0

Failure log: https://treeherder.mozilla.org/logviewer?job_id=361457308&repo=autoland&lineNumber=34498

Comment 17

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b2d73b43bed
Part 4: Mark nsContentUtils::MaybeFireNodeRemoved as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/0b8e3442e4f0
Part 5: Mark Focus*Event::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/a01c249b5af3
Part 6: Mark nsGlobalWindowInner::FireFrameLoadEvent as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/9ed4144fa565
Part 7: Mark nsIEventListenerService::getEventTargetChainFor as can_run_script r=masayuki
https://hg.mozilla.org/integration/autoland/rev/4743c26338e8
Part 8: Mark EventStateManager::Send[Legacy]Event as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/e852d0abe66f
Part 9: Mark EventStateManager::PostHandleKeyboardEvent as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/6bb30c8450cf
Part 10: Mark EventStageManager::DispatchMouseOrPointerEvent as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/77c3bbbd9b7b
Part 11: Mark HTMLFormElement::Reset as CAN_RUN_SCRIPT r=masayuki

Comment 18

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 12: Mark HTMLInputElement::DispatchSelectEvent as CAN_RUN_SCRIPT r=masayuki

Comment 19

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 13: Mark HTMLMenuElement::SendShowEvent as CAN_RUN_SCRIPT r=masayuki

Depends on D134103

Comment 20

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 14: Mark nsGenericHTMLElement::Click/DispatchSimulatedClick as CAN_RUN_SCRIPT r=masayuki

Depends on D134104

Comment 21

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 15: Mark BrowserBridgeChild::RecvMaybeFireEmbedderLoadEvents as CAN_RUN_SCRIPT_BOUNDARY r=masayuki

Depends on D134105

Comment 22

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 16: Mark BrowserParent::RecvReplyKeyEvent/RecvAccessKeyNotHandled as CAN_RUN_SCRIPT_BOUNDARY r=masayuki

Depends on D134106

Comment 23

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 17: Mark nsIScriptLoaderObserver::scriptEvaluated as can_run_script r=masayuki

Depends on D134107

Comment 24

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 18: Mark AsyncTimeEventRunner::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki

Depends on D134108

Comment 25

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 19: Mark XMLDocument::EndLoad as CAN_RUN_SCRIPT_BOUNDARY r=masayuki

Depends on D134109

Comment 26

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 20: Mark XULBroadcastManager::ExecuteOnBroadcastHandlerFor as CAN_RUN_SCRIPT r=masayuki

Depends on D134110

Comment 27

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/9b2d73b43bed
https://hg.mozilla.org/mozilla-central/rev/0b8e3442e4f0
https://hg.mozilla.org/mozilla-central/rev/a01c249b5af3
https://hg.mozilla.org/mozilla-central/rev/9ed4144fa565
https://hg.mozilla.org/mozilla-central/rev/4743c26338e8
https://hg.mozilla.org/mozilla-central/rev/e852d0abe66f
https://hg.mozilla.org/mozilla-central/rev/6bb30c8450cf
https://hg.mozilla.org/mozilla-central/rev/77c3bbbd9b7b

Comment 28

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/27ef29bc1a6a
Part 12: Mark HTMLInputElement::DispatchSelectEvent as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/c27ecbcbd13d
Part 13: Mark HTMLMenuElement::SendShowEvent as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/e03220ef1d65
Part 14: Mark nsGenericHTMLElement::Click/DispatchSimulatedClick as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/39c1b1cc1839
Part 15: Mark BrowserBridgeChild::RecvMaybeFireEmbedderLoadEvents as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/6cfd7b3f6088
Part 16: Mark BrowserParent::RecvReplyKeyEvent/RecvAccessKeyNotHandled as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/e6bce31797bc
Part 17: Mark nsIScriptLoaderObserver::scriptEvaluated as can_run_script r=masayuki
https://hg.mozilla.org/integration/autoland/rev/bb4306053628
Part 18: Mark AsyncTimeEventRunner::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/6276ff43a727
Part 19: Mark XMLDocument::EndLoad as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/b50047134e40
Part 20: Mark XULBroadcastManager::ExecuteOnBroadcastHandlerFor as CAN_RUN_SCRIPT r=masayuki

Comment 29

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/27ef29bc1a6a
https://hg.mozilla.org/mozilla-central/rev/c27ecbcbd13d
https://hg.mozilla.org/mozilla-central/rev/e03220ef1d65
https://hg.mozilla.org/mozilla-central/rev/39c1b1cc1839
https://hg.mozilla.org/mozilla-central/rev/6cfd7b3f6088
https://hg.mozilla.org/mozilla-central/rev/e6bce31797bc
https://hg.mozilla.org/mozilla-central/rev/bb4306053628
https://hg.mozilla.org/mozilla-central/rev/6276ff43a727
https://hg.mozilla.org/mozilla-central/rev/b50047134e40

Comment 30

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 21: Mark nsIDOMXULCommandDispatcher::updateCommands as can_run_script r=masayuki

Comment 31

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 22: Mark nsXULElement::ClickWithInputSource as CAN_RUN_SCRIPT r=masayuki

Depends on D134353

Comment 32

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 23: Mark HasListenersFor* in FocusTarget as CAN_RUN_SCRIPT_BOUNDARY r=masayuki

Depends on D134354

Comment 33

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 24: Mark nsIContentViewer::pageHide as can_run_script r=masayuki

Depends on D134355

Comment 34

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 25: Mark nsLayoutUtils::HasDocumentLevelListenersForApzAwareEvents as CAN_RUN_SCRIPT_BOUNDARY r=masayuki

Depends on D134388

Comment 35

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 26: Mark ScrollFrameHelper::Fire*Event as CAN_RUN_SCRIPT r=masayuki

Depends on D134389

Comment 36

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 27: Mark nsImageBoxFrameEvent::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki

Depends on D134404

Comment 37

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 28: Mark nsXULPopupShownEvent::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki

Depends on D134405

Comment 38

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 29: Mark nsXULPopupManager::HidePopupCallback as CAN_RUN_SCRIPT r=masayuki

Depends on D134406

Comment 39

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 30: Mark nsXULPopupManager::FirePopupShowingEvent as CAN_RUN_SCRIPT r=masayuki

Depends on D134407

Comment 40

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 31: Mark nsTreeBodyFrame::FireScrollEvent as CAN_RUN_SCRIPT r=masayuki

Depends on D134413

Comment 41

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 32: Mark nsHtml5SVGLoadDispatcher::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki

Depends on D134414

Comment 42

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 33: Mark nsDocLoader::DocLoaderIsEmpty as CAN_RUN_SCRIPT r=masayuki

Depends on D134415

Comment 43

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 34: Mark StatusBarEntry::OnMessage as CAN_RUN_SCRIPT r=masayuki

Depends on D134416

Comment 44

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 35: Mark relevant nsMenuX methods to CAN_RUN_SCRIPT r=masayuki

Depends on D134417

Comment 45

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 36: Mark AppWindow::ExecuteCloseHandler as CAN_RUN_SCRIPT r=masayuki

Depends on D134473

Comment 46

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 37: Add strong references for arguments in callers r=masayuki

Depends on D134474

Comment 47

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1539884 - Part 38: Mark EventDispatcher::Dispatch as CAN_RUN_SCRIPT r=masayuki

Depends on D134475

Comment 48

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7e07c76c0dc1
Part 21: Mark nsIDOMXULCommandDispatcher::updateCommands as can_run_script r=masayuki
https://hg.mozilla.org/integration/autoland/rev/b652bdc0f8f5
Part 22: Mark nsXULElement::ClickWithInputSource as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/843729ca64f6
Part 23: Mark HasListenersFor* in FocusTarget as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/2f955ecf3f6b
Part 24: Mark nsIContentViewer::pageHide as can_run_script r=masayuki
https://hg.mozilla.org/integration/autoland/rev/914baba4da41
Part 25: Mark nsLayoutUtils::HasDocumentLevelListenersForApzAwareEvents as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/0d5dc3e6ad50
Part 26: Mark ScrollFrameHelper::Fire*Event as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ad51e216e0a7
Part 27: Mark nsImageBoxFrameEvent::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/226311623b39
Part 28: Mark nsXULPopupShownEvent::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/410d891e4eb8
Part 29: Mark nsXULPopupManager::HidePopupCallback as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/b2c9d1416fea
Part 30: Mark nsXULPopupManager::FirePopupShowingEvent as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/88b62a87d5fa
Part 31: Mark nsTreeBodyFrame::FireScrollEvent as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/ed52c544e38d
Part 32: Mark nsHtml5SVGLoadDispatcher::Run as CAN_RUN_SCRIPT_BOUNDARY r=masayuki
https://hg.mozilla.org/integration/autoland/rev/3490e674ca51
Part 33: Mark nsDocLoader::DocLoaderIsEmpty as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/903333385c89
Part 34: Mark StatusBarEntry::OnMessage as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/174b207e035f
Part 35: Mark relevant nsMenuX methods to CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/28adc7539217
Part 36: Mark AppWindow::ExecuteCloseHandler as CAN_RUN_SCRIPT r=masayuki
https://hg.mozilla.org/integration/autoland/rev/b00ab8f84a81
Part 37: Add strong references for arguments in callers r=masayuki
https://hg.mozilla.org/integration/autoland/rev/080266d5b2a2
Part 38: Mark EventDispatcher::Dispatch as CAN_RUN_SCRIPT r=masayuki

Comment 49

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/7e07c76c0dc1
https://hg.mozilla.org/mozilla-central/rev/b652bdc0f8f5
https://hg.mozilla.org/mozilla-central/rev/843729ca64f6
https://hg.mozilla.org/mozilla-central/rev/2f955ecf3f6b
https://hg.mozilla.org/mozilla-central/rev/914baba4da41
https://hg.mozilla.org/mozilla-central/rev/0d5dc3e6ad50
https://hg.mozilla.org/mozilla-central/rev/ad51e216e0a7
https://hg.mozilla.org/mozilla-central/rev/226311623b39
https://hg.mozilla.org/mozilla-central/rev/410d891e4eb8
https://hg.mozilla.org/mozilla-central/rev/b2c9d1416fea
https://hg.mozilla.org/mozilla-central/rev/88b62a87d5fa
https://hg.mozilla.org/mozilla-central/rev/ed52c544e38d
https://hg.mozilla.org/mozilla-central/rev/3490e674ca51
https://hg.mozilla.org/mozilla-central/rev/903333385c89
https://hg.mozilla.org/mozilla-central/rev/174b207e035f
https://hg.mozilla.org/mozilla-central/rev/28adc7539217
https://hg.mozilla.org/mozilla-central/rev/b00ab8f84a81
https://hg.mozilla.org/mozilla-central/rev/080266d5b2a2