Closed
Bug 1539900
Opened 7 years ago
Closed 7 years ago
Port bug 1539620 Create a brand string that is channel agnostic
Categories
(Thunderbird :: General, task)
Thunderbird
General
Tracking
(Not tracked)
RESOLVED
FIXED
Thunderbird 68.0
People
(Reporter: Paenglab, Assigned: Paenglab)
References
Details
Attachments
(1 file, 1 obsolete file)
|
3.73 KB,
patch
|
jorgk-bmo
:
review+
|
Details | Diff | Splinter Review |
Bug 1539620 added a string that is channel independent. They want to use it in toolkit, so we need this string too to not break.
|
Assignee | |
Comment 1•7 years ago
|
||
|
||
Comment 2•7 years ago
|
||
What about brand-short-name, brand-shorter-name and brand-full-name?
https://hg.mozilla.org/mozilla-central/rev/72493e9686d8#l8.12
|
|
Assignee | |
Comment 3•7 years ago
|
||
We haven't used them, but I can add them to be complete.
|
|
Assignee | |
Comment 4•7 years ago
|
||
Added brand-shorter-name and brand-full-name. brand-short-name was already here.
Attachment #9054272 -
Attachment is obsolete: true
Attachment #9054272 -
Flags: review?(jorgk)
Attachment #9054285 -
Flags: review?(jorgk)
|
|
||
Comment 5•7 years ago
|
||
Comment on attachment 9054285 [details] [diff] [review]
1539900-brandProductName.patch
That looks good.
Attachment #9054285 -
Flags: review?(jorgk) → review+
|
|
||
Updated•7 years ago
|
Keywords: checkin-needed
|
|
||
Comment 6•7 years ago
|
||
Comment on attachment 9054285 [details] [diff] [review]
1539900-brandProductName.patch
Please add a full stop before the reviewer when landing.
Flags: needinfo?(geoff)
Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/318660ce787f
Port bug 1539620: Add a brand product string that doesn't change across different channels. r=jorgk
|
||
Updated•7 years ago
|
Flags: needinfo?(geoff)
Target Milestone: --- → Thunderbird 68.0
|
||
Updated•6 years ago
|
Type: enhancement → task
You need to log in
before you can comment on or make changes to this bug.
Description
•