Closed Bug 1539900 Opened 3 years ago Closed 3 years ago

Port bug 1539620 Create a brand string that is channel agnostic

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 68.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

Bug 1539620 added a string that is channel independent. They want to use it in toolkit, so we need this string too to not break.

Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #9054272 - Flags: review?(jorgk)

What about brand-short-name, brand-shorter-name and brand-full-name?
https://hg.mozilla.org/mozilla-central/rev/72493e9686d8#l8.12

We haven't used them, but I can add them to be complete.

Added brand-shorter-name and brand-full-name. brand-short-name was already here.

Attachment #9054272 - Attachment is obsolete: true
Attachment #9054272 - Flags: review?(jorgk)
Attachment #9054285 - Flags: review?(jorgk)
Comment on attachment 9054285 [details] [diff] [review]
1539900-brandProductName.patch

That looks good.
Attachment #9054285 - Flags: review?(jorgk) → review+
Comment on attachment 9054285 [details] [diff] [review]
1539900-brandProductName.patch

Please add a full stop before the reviewer when landing.
Flags: needinfo?(geoff)

Pushed by geoff@darktrojan.net:
https://hg.mozilla.org/comm-central/rev/318660ce787f
Port bug 1539620: Add a brand product string that doesn't change across different channels. r=jorgk

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: needinfo?(geoff)
Target Milestone: --- → Thunderbird 68.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.