1539994 - textbox[type="number"] doesn't respect size attribute

Status: RESOLVED FIXED

(Thunderbird :: Preferences, defect)

Description

[Geoff Lankow (:darktrojan)]

This happens everywhere, so there may be a more general solution, but in the in-content stuff (which is by far the most common use), we could replicate it in CSS with something like this:

textbox[type="number"][size="1"] {
  width: 5em;
}

Sizes 1-5 are used, AFAICT.

Comment 1

[Richard Marti (:Paenglab)]

Attachment: 1539994-textbox-width.patch

Like Geoff proposed using CSS to set the width. I haven't checked every dialog but every one that uses messenger.css should be fixed. The prefs needed their own styles because they don't use messenger.css.

Comment 2

[Jorg K (CEST = GMT+2)]

Nice, but some are too narrow now:
Outgoing attachments size, only has space for one digit.
Chat idle time, too narrow.

Composition, Autosave is OK.
Display, Advanced, Reading is OK.
Show alert time is OK.

Comment 3

[Richard Marti (:Paenglab)]

Hmm, not here. I have enough space for two digits on this two textboxes.

Comment 4

[Jorg K (CEST = GMT+2)]

The chat box is from here:
https://searchfox.org/comm-central/rev/25a38b7ec4a283e19c8b05762e6b16d567ac72f0/mail/components/preferences/chat.inc.xul#39
It is too small, with and without the patch. 2 digits don't fit. If you don't believe me, I can sent a screenshot.

The cloudfile threshold is from here:
https://searchfox.org/comm-central/rev/25a38b7ec4a283e19c8b05762e6b16d567ac72f0/mail/components/preferences/applications.inc.xul#111
size=1.

The auto-save thing is here:
https://searchfox.org/comm-central/rev/25a38b7ec4a283e19c8b05762e6b16d567ac72f0/mail/components/preferences/compose.inc.xul#39
size=2

The notification duration is
https://searchfox.org/comm-central/rev/25a38b7ec4a283e19c8b05762e6b16d567ac72f0/mail/components/preferences/notifications.xul#32
size=3

We also have
https://searchfox.org/comm-central/rev/25a38b7ec4a283e19c8b05762e6b16d567ac72f0/mail/components/preferences/display.inc.xul#165
size=2

size=1 in not used a lot, in fact only once, and in Calender, it doesn't matter since the field is flexed wide.
https://searchfox.org/comm-central/search?q=size%3D%221%22&case=false&regexp=false&path=*.xul

So I suggest to change applications.inc.xul to size=2 and add size=2 to the chat. That would be appropriate for consistency anyway.

Comment 5

[Jorg K (CEST = GMT+2)]

Attachment: 1539994-textbox-width.patch (JK)

I made the changes I suggested, but the chat box didn't get any bigger :-(

Comment 6

[Geoff Lankow (:darktrojan)]

#timeBeforeAway has a width set in chrome://messenger/skin/preferences/preferences.css.

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: 1539994-textbox-width.patch (JK2)

Thanks, Geoff!

Comment 8

[Jorg K (CEST = GMT+2)]

Comment on attachment 9054715 [details] [diff] [review]
1539994-textbox-width.patch

Let's go with my version, shall we?

Comment 9

[Richard Marti (:Paenglab)]

Comment on attachment 9054746 [details] [diff] [review]
1539994-textbox-width.patch (JK2)

Looks good, thanks.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/b913cc4c3e42
Set a CSS width for textbox[type="number"]. r=jorgk