1540002 - Consider removing interrupt-speed delete from PPluginInstance

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, enhancement)

Description

[Nika Layzell [:nika] (ni? for response)]

There is currently only one user of IPDL's interrupt-speed __delete__ message feature, which is PPluginInstance. It would be nice to be able to remove interrupt-speed __delete__ from IPDL, however we would first need to eliminate PPluginInstance's use of it.

I don't know exactly why this particular message is an interrupt, and I don't see any super-obvious comment explaining why.

IPDL file: https://searchfox.org/mozilla-central/rev/ddd1679c0534f7ddf36cafddd17b710c4fefe3c4/dom/plugins/ipc/PPluginInstance.ipdl#69

There is no overload of the Answer__delete__ method in PluginInstanceChild, meaning that the default implementation (a no-op) is used. The ActorDestroy method will be called, however: https://searchfox.org/mozilla-central/rev/ddd1679c0534f7ddf36cafddd17b710c4fefe3c4/dom/plugins/ipc/PluginInstanceChild.cpp#4036-4044

Comment 1

[Nika Layzell [:nika] (ni? for response)]

ni? qdot to (quickly) figure out if there's a reason why this is the case.

Given that most plugins are preffed off now, we might be able to get away with just not doing this anymore.

Comment 2

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Attachment: Bug 1540002 - Remove intr __delete__ from PPluginInstance;

PPluginInstance's delete was ported from rpc to intr, and is the
only non-async IPDL deletion in the codebase. We should be able to
align this with the rest of the IPDL interfaces and remove the need
for specialized intr delete handling.

Comment 3

[Kyle Machulis [:qdot] [:kmachulis] (INACTIVE)]

Removed the intr delete, and everything still passes on try, so shrug ship it.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=dc1762ed785a0cfa5e2af1d51412f7ededa2b4a2

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/70069fefff73
Remove intr __delete__ from PPluginInstance; r=nika,mccr8

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/70069fefff73