1540010 - Changing download directory pref broken

Status: VERIFIED FIXED

(Thunderbird :: Preferences, enhancement)

Description

[Geoff Lankow (:darktrojan)]

Foiled by this!

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1540010-download-dir-this-1.diff

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9054373 [details] [diff] [review]
1540010-download-dir-this-1.diff

Review of attachment 9054373 [details] [diff] [review]:
-----------------------------------------------------------------

Could you bind it instead?
Preferences.get("browser.download.dir").on("change", gDownloadDirSection.readDownloadDirPref.bind(gDownloadDirSection));

r=mkmelin for that

Comment 3

[Geoff Lankow (:darktrojan)]

Attachment: 1540010-download-dir-this-2.diff

I like my way better, but whatever.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/0cffb1aa9e14
Bind gDownloadDirSection.readDownloadDirPref when called from a listener. r=mkmelin DONTBUILD

Comment 5

[Hades]

Works for me in 68a1 April 5 @Ubuntu 18.10

Comment 6

[Wayne Mery (:wsmwk)]

Verified per hades