Closed Bug 1540112 Opened 8 months ago Closed 8 months ago

Ensure that the addonsManager telemetry event category is enabled before migratePrivateBrowsing is being called

Categories

(Toolkit :: Add-ons Manager, enhancement, P1)

67 Branch
enhancement

Tracking

()

VERIFIED FIXED
mozilla68
Tracking Status
firefox67 --- verified
firefox68 --- verified

People

(Reporter: rpl, Assigned: rpl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

As part of Bug 1529347 we have added a telemetry event that should be recorded when we add the incognito permission automatically on the extensions already installed, when Firefox 67 is running for the first time on an existing profile.

During the QA verification on Bug 1529347 we noticed that those telemetry events are not currently being recorded, even if it doesn't seem to be logging any error or warning message.

After digging a bit into it, it turned out that the reason is that the "addonsManager" telemetry event category is currently enabled when the AddonManager has completed its startup:

Which is happening after the XPIProvider has already executed migratePrivateBrowsing on the installed extensions during its startup:

Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Priority: -- → P1
Blocks: 1529347
Attachment #9054460 - Attachment description: Bug 1540112 - Enable addonsManager telemetry event during the XPIProvider startup. r?aswan! → Bug 1540112 - Enable addonsManager telemetry event category before the AddonManager/XPIProvider have been started. r?aswan!
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/1e40ddd945d1
Enable addonsManager telemetry event category before the AddonManager/XPIProvider have been started. r=aswan,chutten
Status: ASSIGNED → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Verified as fixed in FF68.0a1 (20190404063228) Win7x64 and MacOS 14.0.1

I have followed the steps from https://bugzilla.mozilla.org/show_bug.cgi?id=1529347#c10 and https://bugzilla.mozilla.org/show_bug.cgi?id=1529347#c9 and also performed some regression testing around the telemetry sent on private mode and there were no regression found.

The events are correctly recorded in the following format:
addonsManager action appUpgrade on {"addonId": "{be3295c2-d576-4a7c-9987-a21844164dbb}", "action": "privateBrowsingAllowed"}

Marking bug as verified fixed.

Status: RESOLVED → VERIFIED

Comment on attachment 9054460 [details]
Bug 1540112 - Enable addonsManager telemetry event category before the AddonManager/XPIProvider have been started. r?aswan!

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: Bug 1529347
  • User impact if declined: No visible impact for the users, but when the users will update their existing Firefox profiles to the first Firefox version that has this feature enabled (Firefox 67) the expected telemetry events "for the pre-installed extension migrated to the incognito permission" will not be recorded.
  • Is this code covered by automated tests?: Yes
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: Yes
  • If yes, steps to reproduce: Same STR used to QA verify the fix on Nightly (Bug 1540112 comment 4)
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): The changes applied are minimal and there are automated tests which should be covering the changes enough to ensure no regressions are being introduced.
  • String changes made/needed:
Attachment #9054460 - Flags: approval-mozilla-beta?
Flags: qe-verify?
Flags: qe-verify? → qe-verify+

Comment on attachment 9054460 [details]
Bug 1540112 - Enable addonsManager telemetry event category before the AddonManager/XPIProvider have been started. r?aswan!

Telemetry fix for 67, verified on Nightly by QA, approved for 67 beta 9, let's get it verified post uplift as well.

Attachment #9054460 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Blocks: 1542842

I have verified the issue using the same procedure as in comment4 in FF67.0b9 (20190408123043) Win7x64, MacOS 14.0.1, Ubuntu 14.04x32.
Marking status for firefox67 as verified.

You need to log in before you can comment on or make changes to this bug.