1540141 - Distinguish broadcast trigger from startup trigger in Uptake events

Status: RESOLVED FIXED

(Firefox :: Remote Settings Client, enhancement, P2)

Description

[Mathieu Leplatre [:leplatrem]]

With our current uptake events, we have no way to differentiate synchronizations that were triggered by a push notification from those that were triggered at startup (by the «hello» from the Push service). See Bug 1533668

Some modification could be made to https://searchfox.org/mozilla-central/source/dom/push/PushServiceWebSocket.jsm#574 so that the broadcast handler in Remote Settings could distinguish hello ping from push notifs.

Comment 1

[Mathieu Leplatre [:leplatrem]]

Attachment: Bug 1540141 - Distinguish broadcast trigger from startup trigger in Remote Settings Uptake events

Distinguish broadcast trigger from startup trigger in Remote Settings Uptake events

Comment 2

[Mathieu Leplatre [:leplatrem]]

Lina, I'd really would like to ship this in 68 since it limits our ability to monitor the age of synchronized data.
Do you think you could have a look anytime soon?
Thanks a lot!

Comment 3

[Mathieu Leplatre [:leplatrem]]

I'm sorry, I had missed your feedback on Phabricator :(

Comment 4

[Mathieu Leplatre [:leplatrem]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=03c8335298b449dec3661edcb69507f149590186

Comment 5

[Mathieu Leplatre [:leplatrem]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e70524232a340a4855faa1abc2bb2f4c3ca5292

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/bcd0b9c5c457
Distinguish broadcast trigger from startup trigger in Remote Settings Uptake events r=glasserc,lina

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/bcd0b9c5c457