Distinguish broadcast trigger from startup trigger in Uptake events
Categories
(Firefox :: Remote Settings Client, enhancement, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox68 | --- | fixed |
People
(Reporter: leplatrem, Assigned: leplatrem)
Details
Attachments
(1 file)
With our current uptake events, we have no way to differentiate synchronizations that were triggered by a push notification from those that were triggered at startup (by the «hello» from the Push service). See Bug 1533668
Some modification could be made to https://searchfox.org/mozilla-central/source/dom/push/PushServiceWebSocket.jsm#574 so that the broadcast handler in Remote Settings could distinguish hello ping from push notifs.
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 1•5 years ago
|
||
Distinguish broadcast trigger from startup trigger in Remote Settings Uptake events
|
|
Assignee | |
Comment 2•5 years ago
|
||
Lina, I'd really would like to ship this in 68 since it limits our ability to monitor the age of synchronized data.
Do you think you could have a look anytime soon?
Thanks a lot!
|
|
Assignee | |
Comment 3•5 years ago
|
||
I'm sorry, I had missed your feedback on Phabricator :(
|
|
Assignee | |
Comment 4•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=03c8335298b449dec3661edcb69507f149590186
|
|
Assignee | |
Comment 5•5 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0e70524232a340a4855faa1abc2bb2f4c3ca5292
Pushed by mleplatre@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/bcd0b9c5c457 Distinguish broadcast trigger from startup trigger in Remote Settings Uptake events r=glasserc,lina
|
||
Comment 7•5 years ago
|
||
| bugherder | ||
Description
•