1540146 - Space-separated lists of reviewers should work

Status: RESOLVED WONTFIX

(Conduit :: Lando, enhancement)

Description

[:Gijs (he/him)]

The reviewer regex at:

https://github.com/mozilla-conduit/lando-api/blob/44b74304597e265d44e26535e7729f5865c39097/landoapi/commit_message.py#L44

doesn't seem to allow spaces to separate the reviewers.

An initial space after r= also doesn't seem to work.

Ideally, whitespace should be a valid separator, too.

When doing this, we need to make sure that any "clearly not reviewer" things like DONTBUILD or "[on a] CLOSED TREE" don't get pulled in. It looks like there's already a negative lookahead-y expression there to avoid "a=foo" type things being pulled in, so hopefully something similar would work.

Comment 1

[:glob ✱]

unfortunately as there's no formal/strict syntax on commit descriptions we're left with parsing freeform text.
with this in mind correctly parsing space separated reviewers is problematic and not something that will be supported.