1540152 - Run checks done in push-apk at promote phase, instead of the very last task of the pipeline

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, enhancement)

Description

[Johan Lorenzo [:jlorenzo]]

Over the last 2 weeks, push-apk broke twice: bug 1539933 and bug 1536522. This is not the first time push-apk breaks. Oftentimes, it catches real problems in the APKs. For instance:

• One APK doesn't have the right package name (bug 1536522)
• A new processor architecture was added, but we don't want to ship it to end-users yet (bug 1368484 comment 0, bug 1490502 comment 6).
• Some APKs share the same version code (bug 1477259)

These breakages which happen at the very end of the pipeline could be copied in their own task that runs at each push. This way, we know what push caused the breakage.

Therefore, I'm going to make the mozapkpublisher checks as a standalone script. This script will be called in a docker-worker task. The push-apk task will keep making these checks, no matter if they were run before.

Comment 1

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1540152 - Run checks done in push-apk in promote-phase, instead of the very last task of the pipeline

Run checks done in push-apk in promote-phase, instead of the very last task of the pipeline

Comment 2

[Johan Lorenzo [:jlorenzo]]

We don't have shippable builds on Fennec, so running these checks on hg-pushes can't be done. Instead, we can mitigate the problem by having the checks run at the beginning of release promotion.

Comment 3

[Johan Lorenzo [:jlorenzo]]

Attachment: [mozapkpublisher] Create checks_apks.py script

r+'d by :mhentges at https://github.com/mozilla-releng/mozapkpublisher/pull/178#pullrequestreview-222193750
Landed on master at https://github.com/mozilla-releng/mozapkpublisher/commit/f0b51faebf999a7f89901d8d3e408b74b25825da

Comment 4

[Johan Lorenzo [:jlorenzo]]

Attachment: [mozapkpublisher] check_apks.py: log results out

r+'d by :mhentges at https://github.com/mozilla-releng/mozapkpublisher/pull/182#pullrequestreview-223230665
Landed on master at https://github.com/mozilla-releng/mozapkpublisher/commit/0ac130cdece189f3913952a5c80913504413de7c

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b979e271d955
Run checks done in push-apk in promote-phase, instead of the very last task of the pipeline r=mtabara

Comment 6

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/b979e271d955