1540180 - Accessibility role of `<input type="image"> becomes "text container" when styled as `display: inline-block;`

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Mirko Brodesser (:mbrodesser-Igalia)]

Attachment: patch_add_display_inline_block.txt

Reproduction steps:

1. Add display: inline-block; to input elements (done by the attached patch).

2. Run ./mach test accessible/tests/mochitest/elm/test_HTMLSpec.html, it'll fail.

Expected result: the test passes and the form has a child "pushbutton".
Actual result: the test fails and the form has a child "text container".

Comment 1

[Mirko Brodesser (:mbrodesser-Igalia)]

Fails on Nightly 68.0a1, but probably also earlier versions.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Easier repro is just opening data:text/html,<input type="image" style="display: inline-block"><input type="image">, and see how the role differs in the accessibility inspector.

Ethan, Alex, do you know off-hand what's the code which deals with this? I'm happy to submit a patch to fix it.

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Ah, got it: https://searchfox.org/mozilla-central/rev/73e1da0906e711285c15b0fa5472263c01cbd3f2/layout/generic/nsInlineFrame.cpp#862

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1540180 - The role of a broken input[type="image"] doesn't depend on its display value. r=surkov,eeejay

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b5298ae13542
The role of a broken input[type="image"] doesn't depend on its display value. r=surkov,eeejay

Comment 6

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/b5298ae13542