1540191 - Add ability to disable BITS download for an update using the advertised update.xml

Status: RESOLVED FIXED

(Toolkit :: Application Update, enhancement, P2)

Description

[Robert Strong (they/them - no direct email)]

This will allow us to disable downloading updates remotely if there are problems with the BITS implementation.

I don't think this needs to be implemented on balrog unless we run into a problem and I'll leave that to bhearsum to decide.

Comment 1

[[e-mail] (:bhearsum)]

Any idea how much lead time we would have if we need to use this? If it's <24h, we should probably implement this before we need it.

Comment 2

[Robert Strong (they/them - no direct email)]

From my perspective, if this is needed then disabling updates until this is implemented on balrog would be acceptable. We are testing on oak so we don't think this will be necessary and this is a "just in case".

ritu / sylvestre - does this sound acceptable?

Comment 3

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

I prefer that we be ready (to disable BITS download and fallback to Firefox download of update) before the "Background Update Agent" feature is rolled out broadly to release users. Sometimes leaving Firefox updates disabled completely is not an option, e.g. launch day, bigger marketing campaigns, chemspills for a security issue being exploited in the wild.

Comment 4

[Sylvestre Ledru [:Sylvestre]]

I am no expert in BITS but anything which can give us control and safety to update is a great thing!

Comment 5

[[e-mail] (:bhearsum)]

(In reply to Ritu Kothari (:ritu) from comment #3)

I prefer that we be ready (to disable BITS download and fallback to Firefox
download of update) before the "Background Update Agent" feature is rolled
out broadly to release users. Sometimes leaving Firefox updates disabled
completely is not an option, e.g. launch day, bigger marketing campaigns,
chemspills for a security issue being exploited in the wild.

OK. Robert, just let me know what the mechanism will be to disable BITS and we'll add support in Balrog.

Comment 6

[Robert Strong (they/them - no direct email)]

Attachment: Bug 1540191 - Add ability to disable BITS download for an update using the advertised update.xml. r=bytesized

Comment 7

[Robert Strong (they/them - no direct email)]

Ben, I went with an attribute named disableBITS on the update. When it is present BITS will be disabled.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a55ca10712bb
Add ability to disable BITS download for an update using the advertised update.xml. r=bytesized

Comment 9

[Robert Strong (they/them - no direct email)]

(In reply to Robert Strong (Robert they/them) [:rstrong] (use needinfo to contact me) from comment #7)

Ben, I went with an attribute named disableBITS on the update. When it is present BITS will be disabled.

Best to just go with disableBITS="true"

Comment 10

[Raul Gurzau (:RaulG)]

https://hg.mozilla.org/mozilla-central/rev/a55ca10712bb