Closed Bug 1540191 Opened 7 months ago Closed 6 months ago

Add ability to disable BITS download for an update using the advertised update.xml

Categories

(Toolkit :: Application Update, enhancement, P2)

59 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: rstrong, Assigned: rstrong)

References

Details

Attachments

(1 file)

This will allow us to disable downloading updates remotely if there are problems with the BITS implementation.

I don't think this needs to be implemented on balrog unless we run into a problem and I'll leave that to bhearsum to decide.

Blocks: bits-download
No longer blocks: update-agent

Any idea how much lead time we would have if we need to use this? If it's <24h, we should probably implement this before we need it.

Flags: needinfo?(robert.strong.bugs)

From my perspective, if this is needed then disabling updates until this is implemented on balrog would be acceptable. We are testing on oak so we don't think this will be necessary and this is a "just in case".

ritu / sylvestre - does this sound acceptable?

Flags: needinfo?(sledru)
Flags: needinfo?(robert.strong.bugs)
Flags: needinfo?(rkothari)

I prefer that we be ready (to disable BITS download and fallback to Firefox download of update) before the "Background Update Agent" feature is rolled out broadly to release users. Sometimes leaving Firefox updates disabled completely is not an option, e.g. launch day, bigger marketing campaigns, chemspills for a security issue being exploited in the wild.

Flags: needinfo?(rkothari)

I am no expert in BITS but anything which can give us control and safety to update is a great thing!

Flags: needinfo?(sledru)

(In reply to Ritu Kothari (:ritu) from comment #3)

I prefer that we be ready (to disable BITS download and fallback to Firefox
download of update) before the "Background Update Agent" feature is rolled
out broadly to release users. Sometimes leaving Firefox updates disabled
completely is not an option, e.g. launch day, bigger marketing campaigns,
chemspills for a security issue being exploited in the wild.

OK. Robert, just let me know what the mechanism will be to disable BITS and we'll add support in Balrog.

Ben, I went with an attribute named disableBITS on the update. When it is present BITS will be disabled.

Flags: needinfo?(bhearsum)
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a55ca10712bb
Add ability to disable BITS download for an update using the advertised update.xml. r=bytesized

(In reply to Robert Strong (Robert they/them) [:rstrong] (use needinfo to contact me) from comment #7)

Ben, I went with an attribute named disableBITS on the update. When it is present BITS will be disabled.

Best to just go with disableBITS="true"

Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: needinfo?(bhearsum)
You need to log in before you can comment on or make changes to this bug.