Closed Bug 1540200 Opened 6 years ago Closed 6 years ago

Twitter video control elements are blurry with WebRender enabled

Categories

(Core :: Graphics: WebRender, defect, P1)

Product:
Core
Component:
Graphics: WebRender
Version:
68 Branch
Platform:
Unspecified
All
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- unaffected
firefox68 --- fixed

People

(Reporter: viktor_jaegerskuepper, Assigned: aosmond)

References

(Blocks 2 open bugs, Regression)

Details

(Keywords: regression)

Attachments

(5 files)

example with blurry control elements.png
228.56 KB, image/png
Details
example with sharp control elements.png
213.10 KB, image/png
Details
Bug 1540200 - Part 1. Move picture local rect calculation to update visibility.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540200 - Part 2. Calculate snapped primitive rect and offsets for WebRender on the CPU.
47 bytes, text/x-phabricator-request
Details | Review
Bug 1540200 - Part 3. Reuse snapping offsets calculated on the CPU in the WebRender shaders.
47 bytes, text/x-phabricator-request
Details | Review

OS: Arch Linux
Graphics Hardware: AMD Radeon HD 4850 (RV770)

The control elements shown as overlay on Twitter videos are blurry, see the attached screenshot (ignore the strange looking video itself, this is bug 1536878). Fullscreen videos are not affected.

This is a regression, with mozregression I found:

Last good revision: 0fedcd9cdd51f06c9e177a1b81c04c7ac93e27bf
First bad revision: d0221689e8e9a720dca3bdc7f4c3371c09f6626c

Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=0fedcd9cdd51f06c9e177a1b81c04c7ac93e27bf&tochange=d0221689e8e9a720dca3bdc7f4c3371c09f6626c

This points to bug 1539048.

I can only test on Linux here, so I don't know if other operating systems are affected. Bug 1526756 was about the same issue, but it was fixed before the regression occured.

sharp control elemens for comparison

Blocks: 1539048
Assignee: nobody → aosmond
Priority: -- → P1
Blocks: wr-68

This seems to be fixed by my current snapping investigations, where the primitive rect / visible rect calculations for pictures on the CPU side often need to account for snapping, otherwise there is some slight distortion.

Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Regressed by: 1526756
No longer regressed by: 1526756
See Also: → 1526756

The issue is also present on Windows 10 -- Firefox Nightly 68.0a1 (20190419094745)

OS: Linux → All
No longer blocks: 1539048
status-firefox66: --- → unaffected
status-firefox67: --- → unaffected
status-firefox-esr60: --- → unaffected
Regressed by: 1539048
Version: Trunk → 68 Branch
Blocks: wr-snap

We currently calculate a picture's local rect when we are doing the
first picture traversal. It was composed of the union of the clipped
local rects of its children. However the true local rect of a picture is
the union of the snapped clipped local rects of its children. The
snapping is done in device space, but we won't know the exact transform
until we establish the raster roots, which is based on the picture's
local rect.

As such, we create an estimated local rect which is how we currently
calculate the local rect. Then once the raster roots have been selected,
we recalculate the local rect of the picture based on its children
during update visibility.

This patch should have not contain any functional changes.

We currently do most snapping on the GPU in the shader. However the
picture's local rect needs to take into account the snapping done there,
so we need to calculate this earlier in the pipeline. Instead of using
the clipped primitive local rects to create the picture's own local
rect, we now snap the child local rects first. If no snapping is
required, there should be no functional change. If snapping is required,
there should be fewer visual distortions caused by an inaccurate picture
local rect.

Historically we calculated the snapping offsets in the GPU shaders.
Because this information is always needed on the CPU side, we now just
pass the values into the shader instead of recalculating again. This
ensures we will use the same set of values consistently and makes it
easier to adjust how we snap in the future.

This patch should have no functional change on the output of WebRender
itself.

This change didn't end up being everything I wanted it to be. In particular I had trouble moving from snapping to the visible rect, to snapping to the primitive rect as originally intended. This means there are still outstanding snapping issues (e.g. reddit logo) that I had hoped this would fix. This is arguably better however on its own and I don't want to hold up on fixing everything in one go... we will probably have to settle for incremental wins to meet release timelines ;).

Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fb1438de2bbf Part 1. Move picture local rect calculation to update visibility. r=kvark https://hg.mozilla.org/integration/mozilla-inbound/rev/67e8e1f2f00c Part 2. Calculate snapped primitive rect and offsets for WebRender on the CPU. r=kvark https://hg.mozilla.org/integration/mozilla-inbound/rev/0259eb7967f4 Part 3. Reuse snapping offsets calculated on the CPU in the WebRender shaders. r=kvark

Backed out 3 changesets (Bug 1540200) for reftest failure at: build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3e.html

Push with failure: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=243729562&revision=0259eb7967f41e2476320a899efa85e59a3fe837

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=243767926&repo=mozilla-inbound&lineNumber=82621

Backout link: https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=243729562&revision=f816de04249b85cfb7a83ce06167984b93f96a4a

23:21:39     INFO - REFTEST TEST-START | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3e.html == file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3-ref.html
23:21:39     INFO - REFTEST TEST-LOAD | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3e.html | 21 / 94 (22%)
23:21:39     INFO - ++DOMWINDOW == 42 (0x11ffaa000) [pid = 1464] [serial = 52] [outer = 0x11ff3d020]
23:21:39     INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3e.html == file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3-ref.html | image comparison, max difference: 51, number of differing pixels: 272
23:21:39     INFO - REFTEST   IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAAAAmy5qxAAAZeklEQVR4nO3dS4jd533HYdeBuomLW4fQC8SFZNW60EKghYSCvalWhZZuClkkm4Kh4G2J6cZTSZFkC9kCC+PcJDI4iXGNwGq0yWThEGxFlJAovmCHCIpGscbWJR4kJZ7M6O2iGEIhkaWZfv7njJ4Hvnud97f6cEYztw0AAIDIbVP/AwAAgFuHAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADLXDZAn/+LJbTEAAGB61w2Qh297eFsMAACYngABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAIHPLBMhX/uYr4xv/8I3x/D8/P5Y+tzReeuyl8cqzr4y3XnmreGcAAGDcQgGycPvC2HnHzvH53/382Hv33vHoHz46HvuTx8YTf/rEOHL/kXHi4Ilx+dzl4s0BAOCWdcsEyG+Mkw8sjP1/tH88+ZdPjqWHlsbFn1ws3h4AAG45AuRX91sPj30f3jcO3XtoLD20NK6ev1rcAAAAbhkC5Nds34f3jS9/6svj5WdeHtc2rhW3AACAbU+A/IYtfGBhHLjnwHhx/4tjY22juAcAAGxrAuR97NE/eHR881++OdYurxU3AQCAbUuAvM/tuWvPeOYfnxmrZ1eLuwAAwLYkQG5gu35n13j2n54da1d8EwIAADdDgNzgdt+5e3zrX79V3AYAALYdAXIT23v33vH6868X9wEAgG1FgNzknvizJ8blFX85HQAAboQAuckt3L4wjj94vLgRAABsGwJkE9v7+3vHyqmV4k4AALAtCJBN7tgDx4o7AQDAtiBANrm9d+8dP/vvnxW3AgCAuSdAtmAnDp4obgUAAHNPgGzBvvBXXyhuBQAAc0+AbMF23rFzrJ5dLe4FAABzTYBs0V79j1eLewEAwFwTIFu0pYeWinsBAMBcEyBbtK///deLewEAwFwTIFu0Q/ceKu4FAABzTYBs0fb/8f7iXgAAMNcEyBZt94d2F/cCAIC5dt0A+el//fT/fTt/e+fkAbHZ7bxjZ3EvAACYa9cNkMIjH3lk8oDY7B75yCNTPyMAAMy8mQiQxz/2+OQBsdk9/rHHp35GAACYeTMRIEfuPzJ5QGx2R+4/MvUzAgDAzJuJADn2wLHJA2KzO/bAsamfEQAAZt5MBMjJQycnD4jN7uShk1M/IwAAzLyZCJCVUyuTB8Rmt3JqZepnBACAmTcTAbL+7vo48NEDk0fEze7ARw+M9XfXp35GAACYeTMRIGOMcfzB45OHxM3u+IPHp34+AACYCzMTIMvfW548JG52y99bnvr5AABgLsxMgKz/Yn0cvu/w5DFxozt83+Gx/gs/fgUAAO/HzATIGGO8dvS1yYPiRvfa0demfjYAAJgbMxUga5fX5upbkMP3HR5rl9emfjYAAJgbMxUgY4xx5sUzY/eHdk8eF9fbnt/bM868dGbq5wIAgLkycwGysbYxXvj3FyYPjOvthZ0vjI21jamfCwAA5srMBcgYY1w9f3Us7licPDJ+3b72d18bV89fnfqZAABg7sxkgIwxxlsvvzUO/fmhyWPj/+7QvYfG26++PfXzAADAXJrZALm2cW0sn1geBz9+cPLoeG8HP35wLJ9YHtc2rk39PAAAMJdmNkDGGGPjlxvj7Mmz40uf/NLk8fHFv/7iOHvy7Nj4pf/3AQAAN2umA2SMMa6tXxsX3rgwjn7m6GTxcfSzR8eFNy6Ma+u++QAAgM2Y+QB5z+ry6vjO7u+M3Xd2v6J39527x3f3fXesLq9O/fEBAGBbmJsAGWOMqxeujtNLp5PfkPXVv/3qOL10evz84s+n/tgAALBtzFWAjPG/fyfk0ulL49TTp8bijsWxcPvClkXHwu0LY3HH4jj19Klx8ScX/Z0PAADYYnMXIO9Zu7I2Lp2+NN74zzfG0c8eHXvu2nPT4bHnrj3j6GeOjh8f//G4dPrSWLuyNvXHAwCAbWluA+Q96++uj9Xl1XHuB+fGDxd/OJY+tzSe+/RzY3HH4njqE0+NA/ccGLs+uGvs+uCuceCeA+OpTzw1Fncsjuc+/dz49r99e5x6+tQ494NzY3V5day/uz71xwEAgG1t7gPkV61dWRtX3roy3jnzzrh0+tI4//r5sfKjlfHm998cb37/zbHyo5Vx/vXz49LpS+OdM++MK29f8W0HAACEtlWAAAAAs02AAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQOZ/AMqkKKBgJRUoAAAAAElFTkSuQmCC
23:21:39     INFO - REFTEST   IMAGE 2 (REFERENCE): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAAAAmy5qxAAAX5UlEQVR4nO3dv4vf9QHHcYuDg2IJHdyrU511dCpkdGuy9U/QUqqjOUJ+SKakRKgZDjxohu+BY6I3ZBSJmEEyFKEpxnAgCWfuIOTA+u4UkIJecnc+P9/vN48HvPZ83u/pyec++T4zAAAAIs9M/Q8AAACeHgIEAADICBAAACAjQAAAgIwAAQAAMgIEAADICBAAACAjQAAAgIwAAQAAMgIEAADICBAAACAjQAAAgIwAAQAAMgIEAADICBAAACAjQAAAgIwAAQAAMgIEAADICBAAACAjQAAAgIwAAQAAMgIEAADICBAAACAjQAAAgIwAAQAAMgIEAADI7BkgJ545sRQDAACmJ0AAAICMAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADICBAAAyAgQAAAgI0AAAICMAAEAADICBAAAyAgQAAAg89QEyKnnT40Lr1wYq2+sjtmx2fjkr5+M6x9cH3eu3ynOGQAAGE9RgPzSzh45Ozbe2Rj3v7lfnDkAADy1BMhPtvLsylg/vj6+u/ldcfYAAPDUESA/s/Xj62Nnc6e4AwAAeGoIkF/Ymd+eGZ///fPx439/LO4CAACWngB5jF19++r4YfeH4j4AAGCpCZDH3NrRtfHw/sPiTgAAYGkJkCfYxT9cHFv/3iruBQAAlpIAecJdev3S2N3ZLe4GAACWjgDZx2bHZsXdAADA0hEg+9yN1RvF/QAAwFIRIPvc6RdOj+1vt4s7AgCApSFADrDLb14u7ggAAJaGADngbn92u7gnAABYCgLkgPMWBAAAHp8AOeh+c2Lc/dfd4q4AAGDhCZBD2LX3rgVXBQAAi0+AHMLO//58cVcAALDwBMghbevWVnFfAACw0ATIIc0PEwIAwN4EyCHtyltXivsCAICFJkAOaWtH14r7AgCAhSZADmnnX/YhOgAA7EWAHNLOvXSuuC8AAFhoAuSQdvK5k8V9AQDAQtszQAonnzs5eUAIEAAA+PXNRYCce+nc5AFx0PkTLAAA2NtcBMj5l89PHhAHnY/QAQBgb3MRIGtH1yYPiIPOf8MLAAB7m4sAufLWlckD4qDzQ4QAALC3uQiQG6s3Jg+Ig+7G6o2pjxEAAObeXATI1q2tyQPioNu6tTX1MQIAwNybiwAZY7E/RPcBOgAAPJ65CZBr712bPCT2u2vvXZv6+AAAYCHMTYDc+/re5CGx3937+t7UxwcAAAthbgJkjDEuv3l58ph40l1+8/LUxwYAAAtjrgLk9me3Jw+KJ93tz25PfWwAALAw5ipAxlistyDefgAAwJOZuwDZ/nZ7nH7h9ORxsdfe/937Y/vO9tTHBQAAC2XuAmSMxfhhQj88CAAAT24uA2SMMWbHZpNHxs/t4z9/PPXxAADAQprbANnd2R2XXr80eWz8/z587cOxu7M79fEAAMBCmtsAGWOMB3cfjIuvXpw8Oh7t4qsXx4O7D6Y+FgAAWFhzHSBjjPHw/sOxdnRt8vj46I8fjd1tbz4AAOAg5j5AHtl4Z2Oy+Nh4d2PqxwcAgKWwMAEyxhhf/fOrcebFM1l4nHnxzLg5uzn1YwMAwNJYqAAZY4ydzZ2xfnz9V4+P2Z9mY2dzZ+rHBQCApbJwAfLI5pebY/34+lh5duXQomPl2ZUxOzYbm19uTv14AACwlBY2QB75/j/fj413N8bZI2f3HR5nj5wdn/7t03H/m/tTPw4AACy1hQ+Qn7pz/c64/sH1cfUvV8fs2GysvrE6LrxyYZx6/tQ49fypceGVC2P1jdUxOzYbV9++Or74xxfedgAAQGipAgQAAJhvAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMgIEAAAICNAAACAjAABAAAyAgQAAMj8DyOWKkAQi4fLAAAAAElFTkSuQmCC
23:21:39     INFO - REFTEST INFO | Saved log: START file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3e.html
23:21:39     INFO - REFTEST INFO | Saved log: [CONTENT] OnDocumentLoad triggering AfterOnLoadScripts
23:21:39     INFO - REFTEST INFO | Saved log: Initializing canvas snapshot
23:21:39     INFO - REFTEST INFO | Saved log: DoDrawWindow 0,0,800,1000
23:21:39     INFO - REFTEST INFO | Saved log: [CONTENT] RecordResult fired
23:21:39     INFO - REFTEST INFO | Saved log: RecordResult fired
23:21:39     INFO - REFTEST INFO | Saved log: RecordResult fired
23:21:39     INFO - REFTEST TEST-END | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3e.html == file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3-ref.html
23:21:39     INFO - ++DOMWINDOW == 43 (0x117e8c800) [pid = 1464] [serial = 53] [outer = 0x11ff3d020]
23:21:39     INFO - REFTEST TEST-START | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3f.html == file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3-ref.html
23:21:39     INFO - REFTEST TEST-LOAD | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3f.html | 22 / 94 (23%)
23:21:39     INFO - ++DOMWINDOW == 44 (0x1190a9400) [pid = 1464] [serial = 54] [outer = 0x11ff3d020]
23:21:39     INFO - REFTEST INFO | REFTEST fuzzy test (0, 0) <= (0, 0) <= (1, 126)
23:21:39     INFO - REFTEST TEST-PASS | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3f.html == file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3-ref.html | image comparison, max difference: 0, number of differing pixels: 0
23:21:39     INFO - REFTEST TEST-END | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3f.html == file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3-ref.html
23:21:39     INFO - ++DOMWINDOW == 45 (0x1209d2c00) [pid = 1464] [serial = 55] [outer = 0x11ff3d020]
23:21:39     INFO - REFTEST TEST-START | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3g.html == file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3-ref.html
23:21:39     INFO - REFTEST TEST-LOAD | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3g.html | 23 / 94 (24%)
23:21:39     INFO - ++DOMWINDOW == 46 (0x1209d7400) [pid = 1464] [serial = 56] [outer = 0x11ff3d020]
23:21:39     INFO - REFTEST INFO | REFTEST fuzzy test (0, 0) <= (51, 272) <= (1, 126)
23:21:39     INFO - REFTEST TEST-UNEXPECTED-FAIL | file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3g.html == file:///Users/cltbld/tasks/task_1556664378/build/tests/reftest/tests/layout/reftests/w3c-css/submitted/masking/mask-image-3-ref.html | image comparison, max difference: 51, number of differing pixels: 272
Flags: needinfo?(aosmond)

try (after rebase): https://treeherder.mozilla.org/#/jobs?repo=try&revision=915ad6b2d4f431c0ade554e2c21ad2406d5f0133

This try shows the test passing.

try (more tests/platforms): https://treeherder.mozilla.org/#/jobs?repo=try&revision=cac29739e4656f864c0a07218e944f15b149bcd4

If the above try is green, I will try relanding.

Flags: needinfo?(aosmond)

Looks like it is clean, let's try landing again...

Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/3e4cc0d312d0 Part 1. Move picture local rect calculation to update visibility. r=kvark https://hg.mozilla.org/integration/mozilla-inbound/rev/ff2ca836d8a7 Part 2. Calculate snapped primitive rect and offsets for WebRender on the CPU. r=kvark https://hg.mozilla.org/integration/mozilla-inbound/rev/4352d1f0da34 Part 3. Reuse snapping offsets calculated on the CPU in the WebRender shaders. r=kvark

Backout for causing merge conflicts

Backout: https://hg.mozilla.org/mozilla-central/rev/647a90020b45dc8cdc45370bf3a91df815084b8c

Flags: needinfo?(aosmond)

Looks like some code got moved around, sigh. Let's try this one more time....

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fb4db78ecb3bbce0eb98a7707cc0c60bbccc7856

Flags: needinfo?(aosmond)
Pushed by aosmond@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/403ea69a03b0 Part 1. Move picture local rect calculation to update visibility. r=kvark https://hg.mozilla.org/integration/mozilla-inbound/rev/eefb300b7640 Part 2. Calculate snapped primitive rect and offsets for WebRender on the CPU. r=kvark https://hg.mozilla.org/integration/mozilla-inbound/rev/34510ca46cc6 Part 3. Reuse snapping offsets calculated on the CPU in the WebRender shaders. r=kvark

https://hg.mozilla.org/mozilla-central/rev/403ea69a03b0
https://hg.mozilla.org/mozilla-central/rev/eefb300b7640
https://hg.mozilla.org/mozilla-central/rev/34510ca46cc6

Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Regressions: 1550496
Regressions: 1549993
Regressions: 1550725
No longer regressions: 1549993
Has Regression Range: --- → yes
Blocks: 760358
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: