Closed Bug 1540272 Opened 6 years ago Closed 3 years ago

Unbounded memory growth in main process, causes system instability

Categories

(Toolkit :: Places, defect, P2)

x86_64
Windows 10
defect
Points:
5

Tracking

()

RESOLVED WORKSFORME
Tracking Status
firefox68 --- affected

People

(Reporter: f1041701, Unassigned)

References

()

Details

(Keywords: perf)

Visiting https://meguca.org/a/5962372 [NSFW, expires in 1 week] and scrolling to the bottom causes the main process memory consumption to grow until it crashes. Consuming all available memory also causes other applications to fail.

I think this has something to do with indexdb, but it's hard to debug due to the crashes.

Expected behavior: Either the problematic API being throttled or at most the child process crashing.

Summary: Unbounded memory grwoth in main process, causes system instability → Unbounded memory growth in main process, causes system instability

Enormous stream of visited-status-resolution notifications in the profile. Moving this to Toolkit :: Places

Component: General → Places
Product: Firefox → Toolkit
Status: UNCONFIRMED → NEW
Points: --- → 5
Ever confirmed: true
Keywords: perf
Priority: -- → P2

The issue does not exist any longer. According to their github it has been fixed by batching BroadcastChannel postMessage calls and IndexedDB updates. The underlying DoS vector still exists, not sure if I should close this or not.

let's resolve this based on comment 2, visited-status-resolution had various perf improvements, we'd need an updated example to move further.

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.