62,700 instances of "NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005" emitted from netwerk/base/nsIOService.cpp during linux64 debug testing

RESOLVED FIXED in Firefox 68

Status

()

defect
P1
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: erahm, Assigned: f20160385, Mentored)

Tracking

(Blocks 1 bug)

Trunk
mozilla68
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox68 fixed)

Details

(Whiteboard: [lang=c++][good first bug][domsecurity-active])

Attachments

(1 attachment)

Reporter

Description

3 months ago

62660 WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005: file netwerk/base/nsIOService.cpp, line 942

This warning [1] shows up in the following test suites:

  1707 - test-linux64/debug-web-platform-tests-e10s-10 wpt10
  1706 - test-linux64/debug-web-platform-tests-sw-e10s-10 wpt10
  1472 - test-linux64/debug-web-platform-tests-sw-e10s-4 wpt4
  1469 - test-linux64/debug-web-platform-tests-e10s-4 wpt4
  1460 - test-linux64/debug-web-platform-tests-e10s-18 wpt18
  1457 - test-linux64/debug-web-platform-tests-sw-e10s-18 wpt18
  1427 - test-linux64/debug-web-platform-tests-sw-e10s-14 wpt14
  1421 - test-linux64/debug-web-platform-tests-e10s-14 wpt14
  1404 - test-linux64/debug-web-platform-tests-e10s-15 wpt15
  1402 - test-linux64/debug-web-platform-tests-sw-e10s-15 wpt15
  1397 - test-linux64/debug-web-platform-tests-sw-e10s-11 wpt11
  1396 - test-linux64/debug-web-platform-tests-e10s-11 wpt11
  1303 - test-linux64/debug-web-platform-tests-e10s-9 wpt9
  1301 - test-linux64/debug-web-platform-tests-sw-e10s-9 wpt9
  1194 - test-linux64/debug-web-platform-tests-sw-e10s-5 wpt5
  1194 - test-linux64/debug-web-platform-tests-e10s-5 wpt5
  1139 - test-linux64/debug-web-platform-tests-e10s-3 wpt3
  1138 - test-linux64/debug-web-platform-tests-e10s-8 wpt8
  1138 - test-linux64/debug-web-platform-tests-sw-e10s-3 wpt3
  1138 - test-linux64/debug-web-platform-tests-sw-e10s-8 wpt8
  1126 - test-linux64/debug-web-platform-tests-e10s-7 wpt7
  1125 - test-linux64/debug-web-platform-tests-sw-e10s-7 wpt7
  1049 - test-linux64/debug-web-platform-tests-sw-e10s-13 wpt13
  1048 - test-linux64/debug-web-platform-tests-e10s-13 wpt13
  1043 - test-linux64/debug-web-platform-tests-e10s-16 wpt16
  1039 - test-linux64/debug-web-platform-tests-sw-e10s-16 wpt16
   964 - test-linux64/debug-web-platform-tests-sw-e10s-17 wpt17
   964 - test-linux64/debug-web-platform-tests-e10s-17 wpt17
   957 - test-linux64/debug-web-platform-tests-e10s-2 wpt2
   956 - test-linux64/debug-web-platform-tests-sw-e10s-2 wpt2
   946 - test-linux64/debug-web-platform-tests-e10s-1 wpt1
   944 - test-linux64/debug-web-platform-tests-sw-e10s-1 wpt1
   915 - test-linux64/debug-web-platform-tests-e10s-12 wpt12
   913 - test-linux64/debug-web-platform-tests-sw-e10s-12 wpt12
   719 - test-linux64/debug-web-platform-tests-e10s-6 wpt6
   718 - test-linux64/debug-web-platform-tests-sw-e10s-6 wpt6
   527 - test-linux64/debug-web-platform-tests-wdspec-e10s-1 Wd1
   527 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-1 Wd1
   438 - test-linux64/debug-web-platform-tests-wdspec-sw-e10s-2 Wd2
   438 - test-linux64/debug-web-platform-tests-wdspec-e10s-2 Wd2
   304 - test-linux64/debug-marionette-e10s Mn
   300 - test-linux64/debug-marionette-headless-e10s MnH
   263 - test-linux64/debug-reftest-e10s-1 R1
   261 - test-linux64/debug-reftest-no-accel-e10s-1 Ru1
   261 - test-linux64/debug-reftest-e10s-6 R6
   261 - test-linux64/debug-reftest-e10s-3 R3
   258 - test-linux64/debug-reftest-no-accel-sw-e10s-1 Ru1
   258 - test-linux64/debug-reftest-sw-e10s-6 R6
   257 - test-linux64/debug-reftest-no-accel-e10s-6 Ru6
   255 - test-linux64/debug-reftest-no-accel-sw-e10s-3 Ru3
   254 - test-linux64/debug-reftest-no-accel-sw-e10s-2 Ru2
   254 - test-linux64/debug-web-platform-tests-reftests-e10s-1 Wr1
   253 - test-linux64/debug-reftest-sw-e10s-3 R3
   253 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-1 Wr1
   253 - test-linux64/debug-reftest-no-accel-sw-e10s-6 Ru6
   253 - test-linux64/debug-reftest-sw-e10s-2 R2
   252 - test-linux64/debug-reftest-sw-e10s-1 R1
   252 - test-linux64/debug-reftest-sw-e10s-4 R4
   252 - test-linux64/debug-reftest-no-accel-e10s-3 Ru3
   250 - test-linux64/debug-reftest-no-accel-e10s-2 Ru2
   250 - test-linux64/debug-reftest-no-accel-sw-e10s-4 Ru4
   249 - test-linux64/debug-reftest-e10s-4 R4
   248 - test-linux64/debug-reftest-e10s-2 R2
   248 - test-linux64/debug-reftest-no-accel-e10s-4 Ru4
   247 - test-linux64/debug-reftest-sw-e10s-7 R7
   242 - test-linux64/debug-reftest-no-accel-e10s-7 Ru7
   239 - test-linux64/debug-reftest-e10s-7 R7
   238 - test-linux64/debug-reftest-no-accel-sw-e10s-7 Ru7
   225 - test-linux64/debug-reftest-e10s-5 R5
   222 - test-linux64/debug-reftest-no-accel-e10s-5 Ru5
   219 - test-linux64/debug-reftest-no-accel-sw-e10s-5 Ru5
   218 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-5 Wr5
   218 - test-linux64/debug-reftest-sw-e10s-5 R5
   217 - test-linux64/debug-mochitest-clipboard-e10s cl
   216 - test-linux64/debug-web-platform-tests-reftests-e10s-5 Wr5
   215 - test-linux64/debug-mochitest-clipboard-sw-e10s cl
   213 - test-linux64/debug-web-platform-tests-reftests-e10s-6 Wr6
   211 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-6 Wr6
   209 - test-linux64/debug-web-platform-tests-reftests-e10s-4 Wr4
   209 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-4 Wr4
   204 - test-linux64/debug-web-platform-tests-reftests-e10s-3 Wr3
   204 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-3 Wr3
   195 - test-linux64/debug-web-platform-tests-reftests-e10s-2 Wr2
   191 - test-linux64/debug-web-platform-tests-reftests-sw-e10s-2 Wr2
   182 - test-linux64/debug-mochitest-browser-chrome-e10s-10 bc10
   168 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-6 bc6
   167 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-5 bc5
   166 - test-linux64/debug-mochitest-browser-chrome-e10s-3 bc3
   164 - test-linux64/debug-mochitest-browser-chrome-e10s-9 bc9
   162 - test-linux64/debug-mochitest-browser-chrome-e10s-5 bc5
   157 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-3 bc3
   151 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-11 bc11
   150 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-9 bc9
   147 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-1 bc1
   147 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-7 bc7
   143 - test-linux64/debug-mochitest-browser-chrome-e10s-4 bc4
   141 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-10 bc10
   139 - test-linux64/debug-mochitest-browser-chrome-e10s-6 bc6
   134 - test-linux64/debug-mochitest-browser-chrome-e10s-7 bc7
   133 - test-linux64/debug-mochitest-browser-chrome-e10s-8 bc8
   130 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-4 bc4
   130 - test-linux64/debug-mochitest-browser-chrome-e10s-1 bc1
   129 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-8 bc8
   127 - test-linux64/debug-mochitest-browser-chrome-e10s-2 bc2
   113 - test-linux64/debug-firefox-ui-functional-local-e10s en-US
   100 - test-linux64/debug-mochitest-browser-chrome-e10s-11 bc11
    96 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-2 bc2
    88 - test-linux64/debug-mochitest-plain-headless-sw-e10s-15 h15
    86 - test-linux64/debug-mochitest-plain-headless-e10s-15 h15
    83 - test-linux64/debug-mochitest-sw-e10s-15 15
    78 - test-linux64/debug-mochitest-e10s-15 15
    48 - test-linux64/debug-mochitest-devtools-chrome-e10s-3 dt3
    48 - test-linux64/debug-mochitest-e10s-8 8
    48 - test-linux64/debug-mochitest-sw-e10s-8 8
    47 - test-linux64/debug-mochitest-plain-headless-sw-e10s-5 h5
    47 - test-linux64/debug-mochitest-sw-e10s-5 5
    47 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-2 dt2
    47 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-4 dt4
    47 - test-linux64/debug-mochitest-e10s-5 5
    47 - test-linux64/debug-mochitest-plain-headless-e10s-5 h5
    45 - test-linux64/debug-mochitest-sw-e10s-7 7
    45 - test-linux64/debug-mochitest-devtools-chrome-e10s-2 dt2
    44 - test-linux64/debug-mochitest-sw-e10s-1 1
    44 - test-linux64/debug-mochitest-plain-headless-e10s-11 h11
    44 - test-linux64/debug-mochitest-plain-headless-sw-e10s-11 h11
    44 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-6 dt6
    44 - test-linux64/debug-mochitest-plain-headless-e10s-1 h1
    44 - test-linux64/debug-mochitest-plain-headless-sw-e10s-1 h1
    44 - test-linux64/debug-mochitest-plain-headless-sw-e10s-8 h8
    44 - test-linux64/debug-mochitest-plain-headless-e10s-9 h9
    44 - test-linux64/debug-mochitest-plain-headless-e10s-8 h8
    44 - test-linux64/debug-mochitest-e10s-1 1
    44 - test-linux64/debug-mochitest-plain-headless-sw-e10s-9 h9
    44 - test-linux64/debug-mochitest-devtools-chrome-e10s-6 dt6
    43 - test-linux64/debug-mochitest-devtools-chrome-e10s-4 dt4
    43 - test-linux64/debug-mochitest-plain-headless-sw-e10s-7 h7
    40 - test-linux64/debug-mochitest-e10s-6 6
    40 - test-linux64/debug-mochitest-sw-e10s-10 10
    40 - test-linux64/debug-mochitest-sw-e10s-6 6
    40 - test-linux64/debug-mochitest-e10s-11 11
    40 - test-linux64/debug-mochitest-sw-e10s-14 14
    40 - test-linux64/debug-mochitest-e10s-10 10
    40 - test-linux64/debug-mochitest-plain-headless-e10s-3 h3
    40 - test-linux64/debug-mochitest-e10s-9 9
    40 - test-linux64/debug-mochitest-plain-headless-sw-e10s-6 h6
    40 - test-linux64/debug-mochitest-e10s-3 3
    40 - test-linux64/debug-mochitest-sw-e10s-11 11
    40 - test-linux64/debug-mochitest-e10s-14 14
    40 - test-linux64/debug-mochitest-plain-headless-sw-e10s-3 h3
    40 - test-linux64/debug-mochitest-sw-e10s-9 9
    40 - test-linux64/debug-mochitest-plain-headless-e10s-6 h6
    40 - test-linux64/debug-mochitest-sw-e10s-3 3
    39 - test-linux64/debug-mochitest-devtools-chrome-e10s-5 dt5
    38 - test-linux64/debug-mochitest-e10s-7 7
    38 - test-linux64/debug-mochitest-devtools-chrome-e10s-1 dt1
    38 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-5 dt5
    37 - test-linux64/debug-mochitest-plain-headless-e10s-4 h4
    37 - test-linux64/debug-mochitest-plain-headless-sw-e10s-4 h4
    37 - test-linux64/debug-mochitest-sw-e10s-4 4
    37 - test-linux64/debug-mochitest-e10s-4 4
    36 - test-linux64/debug-mochitest-plain-headless-sw-e10s-13 h13
    36 - test-linux64/debug-mochitest-plain-headless-sw-e10s-14 h14
    36 - test-linux64/debug-mochitest-e10s-12 12
    36 - test-linux64/debug-mochitest-plain-headless-e10s-7 h7
    36 - test-linux64/debug-mochitest-e10s-16 16
    36 - test-linux64/debug-mochitest-plain-headless-sw-e10s-10 h10
    36 - test-linux64/debug-mochitest-plain-headless-e10s-13 h13
    36 - test-linux64/debug-mochitest-sw-e10s-16 16
    36 - test-linux64/debug-mochitest-plain-headless-e10s-14 h14
    36 - test-linux64/debug-mochitest-plain-headless-e10s-10 h10
    36 - test-linux64/debug-mochitest-sw-e10s-12 12
    33 - test-linux64/debug-mochitest-devtools-chrome-e10s-7 dt7
    33 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-7 dt7
    32 - test-linux64/debug-mochitest-plain-headless-sw-e10s-12 h12
    32 - test-linux64/debug-mochitest-sw-e10s-13 13
    32 - test-linux64/debug-mochitest-plain-headless-e10s-16 h16
    32 - test-linux64/debug-mochitest-plain-headless-sw-e10s-16 h16
    32 - test-linux64/debug-mochitest-e10s-13 13
    32 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-8 dt8
    32 - test-linux64/debug-mochitest-plain-headless-e10s-12 h12
    30 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-1 dt1
    28 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-14 bc14
    27 - test-linux64/debug-mochitest-browser-chrome-e10s-14 bc14
    27 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-3 dt3
    25 - test-linux64/debug-mochitest-plain-headless-e10s-2 h2
    25 - test-linux64/debug-mochitest-e10s-2 2
    25 - test-linux64/debug-mochitest-plain-headless-sw-e10s-2 h2
    25 - test-linux64/debug-mochitest-sw-e10s-2 2
    24 - test-linux64/debug-mochitest-media-sw-e10s-3 mda3
    24 - test-linux64/debug-mochitest-browser-chrome-e10s-12 bc12
    24 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-12 bc12
    24 - test-linux64/debug-mochitest-media-e10s-3 mda3
    24 - test-linux64/debug-mochitest-media-e10s-spi-3 mda3
    21 - test-linux64/debug-firefox-ui-functional-remote-e10s en-US
    20 - test-linux64/debug-mochitest-webgl1-core-sw-e10s gl1c
    20 - test-linux64/debug-mochitest-webgl1-core-e10s gl1c
    20 - test-linux64/debug-mochitest-gpu-sw-e10s gpu
    20 - test-linux64/debug-mochitest-devtools-chrome-e10s-8 dt8
    20 - test-linux64/debug-mochitest-gpu-e10s gpu
    19 - test-linux64/debug-telemetry-tests-client-e10s c
    17 - test-linux64/debug-mochitest-chrome-sw-1 c1
    17 - test-linux64/debug-mochitest-chrome-1 c1
    12 - test-linux64/debug-mochitest-browser-chrome-e10s-15 bc15
    12 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-16 bc16
    12 - test-linux64/debug-mochitest-chrome-sw-3 c3
    12 - test-linux64/debug-mochitest-media-e10s-spi-1 mda1
    12 - test-linux64/debug-mochitest-media-e10s-spi-2 mda2
    12 - test-linux64/debug-mochitest-media-sw-e10s-1 mda1
    12 - test-linux64/debug-mochitest-chrome-3 c3
    12 - test-linux64/debug-mochitest-browser-chrome-e10s-16 bc16
    12 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-15 bc15
    12 - test-linux64/debug-mochitest-media-e10s-2 mda2
    12 - test-linux64/debug-mochitest-browser-chrome-e10s-13 bc13
    12 - test-linux64/debug-mochitest-browser-chrome-sw-e10s-13 bc13
    12 - test-linux64/debug-mochitest-devtools-chrome-e10s-11 dt11
    12 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-11 dt11
    12 - test-linux64/debug-mochitest-media-sw-e10s-2 mda2
    12 - test-linux64/debug-mochitest-media-e10s-1 mda1
    11 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-12 dt12
    10 - test-linux64/debug-reftest-e10s-8 R8
    10 - test-linux64/debug-mochitest-devtools-chrome-e10s-13 dt13
    10 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-9 dt9
    10 - test-linux64/debug-reftest-no-accel-sw-e10s-8 Ru8
    10 - test-linux64/debug-mochitest-devtools-chrome-e10s-15 dt15
    10 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-14 dt14
    10 - test-linux64/debug-mochitest-devtools-chrome-e10s-14 dt14
    10 - test-linux64/debug-mochitest-devtools-chrome-e10s-9 dt9
    10 - test-linux64/debug-reftest-sw-e10s-8 R8
    10 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-15 dt15
    10 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-10 dt10
    10 - test-linux64/debug-mochitest-devtools-chrome-e10s-12 dt12
    10 - test-linux64/debug-mochitest-devtools-chrome-e10s-10 dt10
    10 - test-linux64/debug-mochitest-devtools-chrome-e10s-16 dt16
    10 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-13 dt13
    10 - test-linux64/debug-mochitest-devtools-chrome-sw-e10s-16 dt16
     9 - test-linux64/debug-reftest-no-accel-e10s-8 Ru8
     5 - test-linux64/debug-crashtest-sw-e10s C
     5 - test-linux64/debug-crashtest-e10s C
     4 - test-linux64/debug-mochitest-webgl1-ext-sw-e10s gl1e
     4 - test-linux64/debug-mochitest-webgl1-ext-e10s gl1e
     3 - test-linux64/debug-mochitest-chrome-2 c2
     3 - test-linux64/debug-mochitest-chrome-sw-2 c2

It shows up in 18935 tests. A few of the most prevalent:

  4200 - [e10s] Shutdown
    41 - [e10s] js/xpconnect/tests/marionette/test_loader_global_sharing.py TestLoaderGlobalSharing.test_global_sharing_settings
    40 - [e10s] /webdriver/tests/new_window/user_prompts.py
    36 - [e10s] /webdriver/tests/get_element_css_value/user_prompts.py
    36 - [e10s] /webdriver/tests/maximize_window/user_prompts.py
    36 - [e10s] /webdriver/tests/get_current_url/user_prompts.py
    36 - [e10s] /webdriver/tests/get_window_handle/user_prompts.py
    36 - [e10s] /webdriver/tests/find_elements/user_prompts.py
    36 - [e10s] /webdriver/tests/get_element_text/user_prompts.py
    36 - [e10s] /webdriver/tests/find_element/user_prompts.py

[1] https://hg.mozilla.org/mozilla-central/annotate/69e9ee0ef3dd/netwerk/base/nsIOService.cpp#l942

Reporter

Comment 1

3 months ago

It looks like bug 1528934 converted code that didn't warn to code that does warn via NS_ENSURE. To fix this bug we need to replace the NS_ENSURE call with an if statement instead, something like:

if (NS_FAILED(rv)) return rv;

Steps to contributing:

  1. Get setup to build Firefox
  2. Modify nsIOService::NewChannelFromURIWithProxyFlagsInternal to use an if statement rather than NS_ENSURE
  3. Verify that your code builds following the steps from part 1
  4. Submit a patch for review
Blocks: 1528934
Mentor: erahm
Whiteboard: [lang=c++][good first bug]

Chris, this looks like a good bug for Basti? :)

Flags: needinfo?(ckerschb)
Assignee

Comment 3

3 months ago

Hi, I'm an Outreachy applicant. Please assign this bug to me.

Flags: needinfo?(erahm)
Reporter

Comment 4

3 months ago

(In reply to Khyati Agarwal from comment #3)

Hi, I'm an Outreachy applicant. Please assign this bug to me.

Hi Khyati, I'd be happy to assign the bug once you take the first few steps towards putting together a patch. Let us know if you run into any trouble and feel free to ask around in #introduction or #developers on irc.mozilla.org for help.

Flags: needinfo?(erahm)
Assignee

Comment 5

3 months ago

62,700 instances of "NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005" emitted from netwerk/base/nsIOService.cpp during linux64 debug testing

Assignee

Comment 6

3 months ago

I built it on my machine, and it worked fine. Please check the submitted patch.

Flags: needinfo?(erahm)
Reporter

Comment 7

3 months ago

(In reply to Khyati Agarwal from comment #6)

I built it on my machine, and it worked fine. Please check the submitted patch.

Thanks Khyati, that was super quick! It looks like you've fixed several good-first-bugs now, I'd suggest that you ask your reviewers if they can find you a "good second bug" that is a little more in depth so that we can give other new contributors a chance to try these bugs out. There are a few more warning related bugs hanging off of bug 765224 that it would be helpful to take a look at and I'd be happy to help you work on those if you'd like.

Flags: needinfo?(erahm)
Reporter

Updated

3 months ago
Assignee: nobody → f20160385
Assignee

Comment 8

3 months ago

Thanks Khyati, that was super quick! It looks like you've fixed several good-first-bugs now, I'd suggest that you ask your reviewers if they can find you a "good second bug" that is a little more in depth so that we can give other new contributors a chance to try these bugs out. There are a few more warning related bugs hanging off of bug 765224 that it would be helpful to take a look at and I'd be happy to help you work on those if you'd like.

Okay, I'll check these out. Thanks!
It would be great if you could help me finding some "good second bugs" related to C++.

(In reply to Khyati Agarwal from comment #8)

Thanks Khyati, that was super quick! It looks like you've fixed several good-first-bugs now, I'd suggest that you ask your reviewers if they can find you a "good second bug" that is a little more in depth so that we can give other new contributors a chance to try these bugs out. There are a few more warning related bugs hanging off of bug 765224 that it would be helpful to take a look at and I'd be happy to help you work on those if you'd like.

Okay, I'll check these out. Thanks!
It would be great if you could help me finding some "good second bugs" related to C++.

Thanks for providing the fix. I have a number of bugs that do need fixing, e.g. Bug 1315195 might be a good one for you. Feel free to reach out to me and I can assemble a list of bugs that are good second C++ bugs.

Flags: needinfo?(ckerschb)
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [lang=c++][good first bug] → [lang=c++][good first bug][domsecurity-active]
Assignee

Updated

2 months ago
Keywords: checkin-needed

Comment 10

2 months ago

Pushed by nerli@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/130653bcfef0
62,700 instances of "NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80004005" emitted from netwerk/base/nsIOService.cpp during linux64 debug testing r=valentin

Keywords: checkin-needed

Comment 11

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.