1540325 - Perma tier2 clang tidy [taskcluster:error] Task timeout after 3600 seconds. Force killing container. readability-inconsistent-declaration-parameter-name has a definition with different parameter names

Status: RESOLVED FIXED

(Firefox Build System :: General, defect, P5)

Description

[Treeherder Bug Filer]

#[markdown(off)]
Filed by: apavel [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=236297218&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/e6jZbb3LSJaVAbGoWmX3YQ/runs/0/artifacts/public/logs/live_backing.log

[task 2019-03-27T06:08:23.935Z] {
[task 2019-03-27T06:08:23.963Z] Warning: readability-braces-around-statements in /builds/worker/checkouts/gecko/js/src/irregexp/RegExpEngine.h: statement should be inside braces
[task 2019-03-27T06:08:23.963Z] /builds/worker/checkouts/gecko/js/src/irregexp/RegExpEngine.h:631:13: warning: statement should be inside braces [readability-braces-around-statements]
[task 2019-03-27T06:08:23.990Z] else
[task 2019-03-27T06:08:24.018Z] ^
[taskcluster:error] Task timeout after 3600 seconds. Force killing container.
[task 2019-03-27T06:08:24.045Z] {
[task 2019-03-27T06:08:24.074Z] Warning: readability-inconsistent-declaration-parameter-name in /builds/worker/checkouts/gecko/js/src/irregexp/RegExpEngine.h: function 'js::irregexp::BackReferenceNode::EatsAtLeast' has a definition with different parameter names
[task 2019-03-27T06:08:24.074Z] /builds/worker/checkouts/gecko/js/src/irregexp/RegExpEngine.h:895:17: warning: function 'js::irregexp::BackReferenceNode::EatsAtLeast' has a definition with different parameter names [readability-inconsistent-declaration-parameter-name]
[task 2019-03-27T06:08:24.102Z] virtual int EatsAtLeast(int still_to_find,
[taskcluster 2019-03-27 06:08:24.678Z] === Task Finished ===
[taskcluster 2019-03-27 06:08:24.679Z] Unsuccessful task run with exit code: -1 completed in 3626.128 seconds

This first occurred on this merge: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?changeset=528eacf3d3f64eb49bd53a7e16ca2c9103bdbad9

Mike can it be from Bug 1537641?

Comment 1

[Mike Hommey [:glandium]]

Mike can it be from Bug 1537641?

No, it can't.

Comment 2

[Andreea Pavel [:apavel]]

Kim can you please assign someone to take a look at this?

Failure rate is high, however this was classified as bug 1411358.

Comment 3

[Mike Hommey [:glandium]]

In the particular one linked in comment 0, the problem is that hg status --rev 'max(ancestors(tip) and public())' -q --no-status returned nothing, making TRY_MODIFIED_FILES empty, which apparently triggered doing a full clang-tidy of the entire tree, and that doesn't finish within the allocated hour. The latter is probably related to the worker type used for those jobs being under-resourced for a full tree clang-tidy (that one used c3.xlarge, which have only 4 cores, which is not a lot to do a full tree analysis).

It's worth noting that one rerun/retrigger failed differently, with a non empty but very large TRY_MODIFIED_FILES, and failed with bug 1538770.

So probably the main problem here is TRY_MODIFIED_FILES being empty.

Comment 4

[Mike Hommey [:glandium]]

hg status --rev 'max(ancestors(tip) and public())' -q --no-status seems to be designed for try, but doesn't quite fit the bill on other branches...

Comment 5

[Bastien Abadie [:bastien]]

This should be fixed by Bug 1538770. I would need Andrew's review on this bug.

Comment 6

[Mike Hommey [:glandium]]

I don't think get_outgoing_files is going to do the right thing on non-try.

Comment 7

[Bastien Abadie [:bastien]]

Maybe we can limit the clang tasks to try runs by using run_on_projects ?

Comment 8

[Intermittent Failures Robot]

2 failures in 3910 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 2

Platform breakdown:

• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1540325&startday=2019-03-25&endday=2019-03-31&tree=all

Comment 9

[Bastien Abadie [:bastien]]

Attachment: Bug 1540325 - Run clang tools tasks only on try & code-review, r=glandium

Comment 10

[Bastien Abadie [:bastien]]

I made a patch that limit the generation of clang tools tasks to try & code-review.

I tested it by running ./mach taskgraph morphed with the parameters.yml from the failed task in top comment.
The clang tools task are not present anymore in the generated taskgraph with this patch, but are still there while running against a try push or code-review push

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9b9c50876092
Run clang tools tasks only on try & code-review, r=glandium,sylvestre

Comment 12

[Narcis Beleuzu [:NarcisB]]

Backed out for Linting failure on clang.yml

Backout link: https://hg.mozilla.org/integration/autoland/rev/cff212107d958f87f735f80490b52cc414b6281b
Log link: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=237535738&repo=autoland&lineNumber=291

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/cb394c9bb56d
Run clang tools tasks only on try & code-review, r=glandium,sylvestre

Comment 14

[Kim Moir [:kmoir] ET]

Looks like a fix has landed for this so I will close the ni for me.

Comment 15

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/cb394c9bb56d

Comment 16

[Intermittent Failures Robot]

2 failures in 2843 pushes (0.001 failures/push) were associated with this bug in the last 7 days.

Repository breakdown:

• mozilla-inbound: 1
• autoland: 1

Platform breakdown:

• linux64: 2

For more details, see:
https://treeherder.mozilla.org/intermittent-failures.html#/bugdetails?bug=1540325&startday=2019-04-01&endday=2019-04-07&tree=all