Closed Bug 1540400 Opened 1 year ago Closed 1 year ago

[wpt-sync] Sync PR 16114 - Revert "Change unoptimized-images feature policy to unoptimized-lossy-images."

Categories

(Core :: DOM: Core & HTML, enhancement, P4)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: wptsync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 16114 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/16114
Details from upstream follow.

Peter Kasting <pkasting@chromium.org> wrote:

Revert "Change unoptimized-images feature policy to unoptimized-lossy-images."

This reverts commit efbe41b8ceda53be0e82b4c9a4576cc95c84a3b5.

Reason for revert: Mac bots are failing consistently, see e.g. https://ci.chromium.org/p/chromium/builders/ci/Mac10.10%20Tests/40949

Original change's description:

Change unoptimized-images feature policy to unoptimized-lossy-images.

This makes it more clear that this policy applies only to lossy image
types (for now, just JPEG). This patch also makes the implementation
more generic in order to make the policy compatible with parsed
policy values and to pave the way for implementing a
lossless-enforcing version of the unoptimized-images policy as well.

These changes have been pulled from a larger partially reviewed CL:
https://chromium-review.googlesource.com/c/chromium/src/+/1524869

Bug: 942659
Change-Id: I0242ac900b1653b89d6d8dbd63616003dcaaba62
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1531354
Commit-Queue: Paul Meyer &lt;paulmeyer@chromium.org>
Reviewed-by: Paul Meyer &lt;paulmeyer@chromium.org>
Reviewed-by: Robert Flack &lt;flackr@chromium.org>
Reviewed-by: Philip Rogers &lt;pdr@chromium.org>
Reviewed-by: Ken Buchanan &lt;kenrb@chromium.org>
Reviewed-by: Ian Clelland &lt;iclelland@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644488}

TBR=flackr@chromium.org,kenrb@chromium.org,pdr@chromium.org,paulmeyer@chromium.org,iclelland@chromium.org

Change-Id: I0dc0449dc2d07c5dafa84c7123ec664c902a73fb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 942659
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1540145
Reviewed-by: Peter Kasting &lt;pkasting@chromium.org>
Commit-Queue: Peter Kasting &lt;pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#644637}

PR 16114 applied with additional changes from upstream: 3894f179195a675bf15a8d7aa25bb261701541bc, f19a0c4003dc469cd0972dab425acdcdd3a7d1d7
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core
Failed to get results from try push
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1972694bafbe
[wpt PR 16114] - Revert "Change unoptimized-images feature policy to unoptimized-lossy-images.", a=testonly
Pushed by james@hoppipolla.co.uk:
https://hg.mozilla.org/integration/mozilla-inbound/rev/48f6da6608ae
[wpt PR 16114] - Revert "Change unoptimized-images feature policy to unoptimized-lossy-images.", a=testonly
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.