Closed Bug 1540433 Opened 5 years ago Closed 5 years ago

OpenVR gamepad id are null-padded

Categories

(Core :: WebVR, defect)

68 Branch
defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1540206
Tracking Status
firefox68 --- affected

People

(Reporter: gfodor, Unassigned)

References

Details

In Firefox 68 nightly, calling navigator.getGamepads() when using a Vive results in 2 gamepads with the normal "OpenVR Gamepad" id but the id string is padded at the end by a long stream of null characters. SteamVR version 1.3.2

Repro steps:

  • With Steam VR running with a Vive
  • Go to hubs.mozilla.com
  • Go into a room in VR mode
  • In the JS console, call navigator.getGamepads()
  • The two gamepads returned for the vive controllers have long sequences of null characters in their .id's

Confirmed this also happens for Oculus Touch controllers when using Oculus

I suspect we cause this regression at Bug 1537550 because we were using PlainOldDataSerializer to replace the pervious serialization metohd. FxR also happens this issue (Bug 1540206).

Blocks: 1537550

We do need to add tests for checking VRPuppet displayId and controllerId as well.

We have fixed it at Bug 1540206. Please go ahead to have a try!

Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → DUPLICATE
You need to log in before you can comment on or make changes to this bug.