Port Bug 1531176 "Split the Google key management between gls and safe browsing" to SeaMonkey

RESOLVED FIXED in seamonkey2.65

Status

enhancement
--
trivial
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: frg, Assigned: frg)

Tracking

SeaMonkey 2.64
seamonkey2.65

SeaMonkey Tracking Flags

(seamonkey2.49esr unaffected, seamonkey2.53 unaffected, seamonkey2.57esr fixed, seamonkey2.63 unaffected)

Details

Attachments

(2 attachments)

We still use %GOOGLE_API_KEY% in our prefs. This needs to be changed to %GOOGLE_SAFEBROWSING_API_KEY%

We also need to change our build config files

ac_add_options --with-google-api-keyfile=...

needs to become

ac_add_options --with-google-location-service-api-keyfile=...
ac_add_options --with-google-safebrowsing-api-keyfile=...

Ourt key is good for both geolocation and safebrowsing so the build files can point to the same key file.

2.57 is affected. I might backport to 2.53 later.

prefs

Attachment #9054721 - Flags: review?(iann_bugzilla)
Attachment #9054721 - Flags: approval-comm-esr60?

Build files

Attachment #9054722 - Flags: review?(iann_bugzilla)
Attachment #9054722 - Flags: approval-comm-esr60?
Comment on attachment 9054721 [details] [diff] [review]
1540443-apikeyprefs.patch

>+++ b/suite/browser/browser-prefs.js
>-pref("geo.wifi.uri", "https://www.googleapis.com/geolocation/v1/geolocate?key=%GOOGLE_API_KEY%");
>+pref("geo.wifi.uri", "https://www.googleapis.com/geolocation/v1/geolocate?key=%GOOGLE_SAFEBROWSING_API_KEY%");

This should be to %GOOGLE_LOCATION_SERVICE_API_KEY%

r/a=me with that fixed
Attachment #9054721 - Flags: review?(iann_bugzilla)
Attachment #9054721 - Flags: review+
Attachment #9054721 - Flags: approval-comm-esr60?
Attachment #9054721 - Flags: approval-comm-esr60+
Comment on attachment 9054722 [details] [diff] [review]
1540443-apikeybuild.patch

r/a=me
Attachment #9054722 - Flags: review?(iann_bugzilla)
Attachment #9054722 - Flags: review+
Attachment #9054722 - Flags: approval-comm-esr60?
Attachment #9054722 - Flags: approval-comm-esr60+

Pushed by frgrahl@gmx.net:
https://hg.mozilla.org/comm-central/rev/b2c8b952266f
Part 1: Change GOOGLE_API_KEY to GOOGLE_SAFEBROWSING_API_KEY in SeaMonkey preferences. r=IanN
https://hg.mozilla.org/comm-central/rev/9318d65e46d6
Part 2: Split google api key file for safebrowsing and geolocation in suite build files. r=IanN

Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → seamonkey2.65

https://hg.mozilla.org/releases/comm-esr60/rev/fc445ec9ed223e73d8aca608ffe35378c803f8a0
Part 1: Change GOOGLE_API_KEY to GOOGLE_SAFEBROWSING_API_KEY in SeaMonkey preferences. r=IanN a=IanN

https://hg.mozilla.org/releases/comm-esr60/rev/9732387a6863dbd68d4f6df32d65a807d6f232a2
Part 2: Split google api key file for safebrowsing and geolocation in suite build files. r=IanN a=IanN

You need to log in before you can comment on or make changes to this bug.