Closed Bug 1540530 Opened 5 months ago Closed 4 months ago

Reloading Customize Mode tab breaks it

Categories

(Firefox :: Toolbars and Customization, defect, P1)

defect

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: Oriol, Assigned: Oriol)

References

Details

Attachments

(1 file)

Open Customize Mode
Open browser console and enter:

gBrowser.reloadTab(gBrowser.selectedTab);

(alternatively, right-click the tab and choose "Reload Tab")

Result: Customize Mode is still open but it's broken.
Note that the tab title becomes "New tab" instead of "Customize Nightly".
If you switch to another tab, and then go back to the Customize Mode one, it will be blank.

This is because of https://searchfox.org/mozilla-central/rev/73e1da0906e711285c15b0fa5472263c01cbd3f2/browser/components/customizableui/CustomizeMode.jsm#79

Customize Mode shouldn't be teared down when the tab navigates to about:blank

Keywords: checkin-needed

Pushed by cbrindusan@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/dfe05bf32adb
Don't tear down Customize Mode when reloading about:blank. r=dao

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
QA Whiteboard: [qa-68b-p2]
You need to log in before you can comment on or make changes to this bug.